X-Git-Url: http://nitlanguage.org diff --git a/src/nitpm.nit b/src/nitpm.nit index d61db8f..1e9de9c 100644 --- a/src/nitpm.nit +++ b/src/nitpm.nit @@ -104,11 +104,10 @@ class CommandInstall do if package_id.is_package_name then # Ask a centralized server - # TODO choose a future safe URL # TODO customizable server list # TODO parse ini file in memory - var url = "https://xymus.net/nitpm/{package_id}.ini" + var url = "https://nitlanguage.org/catalog/p/{package_id}.ini" var ini_path = "/tmp/{package_id}.ini" if verbose then print "Looking for a package description at '{url}'" @@ -247,39 +246,58 @@ class CommandUninstall super Command redef fun name do return "uninstall" - redef fun usage do return "nitpm uninstall " - redef fun description do return "Uninstall a package" + redef fun usage do return "nitpm uninstall [-f] [=version] [package1 ...]" + redef fun description do return "Uninstall packages" redef fun apply(args) do - if args.length != 1 then + var opt_force = "-f" + var force = args.has(opt_force) + if force then args.remove(opt_force) + + if args.is_empty then print_local_help exit 1 end - var name = args.first - var target_dir = nitpm_lib_dir / name + for name in args do - if not target_dir.file_exists or not target_dir.to_path.is_dir then - print_error "Package not found" - exit 1 - end + var clean_nitpm_lib_dir = nitpm_lib_dir.simplify_path + var target_dir = clean_nitpm_lib_dir / name - # Ask confirmation - var response = prompt("Delete {target_dir.escape_to_sh}? [Y/n] ") - var accept = response != null and - (response.to_lower == "y" or response.to_lower == "yes" or response == "") - if not accept then return + # Check validity of the package to delete + target_dir = target_dir.simplify_path + var within_dir = target_dir.has_prefix(clean_nitpm_lib_dir + "/") and + target_dir.length > clean_nitpm_lib_dir.length + 1 + var valid_name = name.length > 0 and name.chars.first.is_lower + if not valid_name or not within_dir then + print_error "Package name '{name}' is invalid" + continue + end - var cmd = "rm -rf {target_dir.escape_to_sh}" - if verbose then print "+ {cmd}" + if not target_dir.file_exists or not target_dir.to_path.is_dir then + print_error "Package not found" + exit 1 + end - var proc = new Process("sh", "-c", cmd) - proc.wait + # Ask confirmation + if not force then + var response = prompt("Delete {target_dir.escape_to_sh}? [Y/n] ") + var accept = response != null and + (response.to_lower == "y" or response.to_lower == "yes" or response == "") + if not accept then return + end - if proc.status != 0 then - print_error "Uninstall failed" - exit 1 + var cmd = "rm -rf {target_dir.escape_to_sh}" + if verbose then print "+ {cmd}" + + var proc = new Process("sh", "-c", cmd) + proc.wait + + if proc.status != 0 then + print_error "Uninstall failed" + exit 1 + end end end end @@ -352,10 +370,10 @@ redef class Sys var opts = new OptionContext # Help option - var opt_help = new OptionBool("Show this help message", "--help", "-h") + var opt_help = new OptionBool("Show help message", "-h", "--help") # Verbose mode option - var opt_verbose = new OptionBool("Print more information", "--verbose", "-v") + var opt_verbose = new OptionBool("Print more information", "-v", "--verbose") private fun verbose: Bool do return opt_verbose.value # All command line actions, mapped to their short `name`