X-Git-Url: http://nitlanguage.org?ds=sidebyside diff --git a/src/metrics/nullables_metrics.nit b/src/metrics/nullables_metrics.nit index 6992ff8..f88c3ba 100644 --- a/src/metrics/nullables_metrics.nit +++ b/src/metrics/nullables_metrics.nit @@ -22,6 +22,8 @@ import mclasses_metrics import semantize redef class ToolContext + + # Nullable types related metrics var nullables_metrics_phase: Phase = new NullablesMetricsPhase(self, null) end @@ -61,7 +63,7 @@ private class NullablesMetricsPhase mclasses.add_all(mod_mclasses) metrics.collect(new HashSet[MClass].from(mod_mclasses)) metrics.to_console(1, not toolcontext.opt_nocolors.value) - if csv then metrics.to_csv.save("{out}/{mgroup}.csv") + if csv then metrics.to_csv.write_to_file("{out}/{mgroup}.csv") end end if not mclasses.is_empty then @@ -70,7 +72,7 @@ private class NullablesMetricsPhase print toolcontext.format_h2("\n ## global metrics") metrics.collect(mclasses) metrics.to_console(1, not toolcontext.opt_nocolors.value) - if csv then metrics.to_csv.save("{out}/summary.csv") + if csv then metrics.to_csv.write_to_file("{out}/summary.csv") end compute_nullables_metrics(toolcontext.modelbuilder) @@ -84,14 +86,6 @@ class CNBNA redef fun name do return "cnbna" redef fun desc do return "number of accessible nullable attributes (inherited + local)" - var mainmodule: MModule - var model_view: ModelView - - init(mainmodule: MModule, model_view: ModelView) do - self.mainmodule = mainmodule - self.model_view = model_view - end - redef fun collect(mclasses) do for mclass in mclasses do var all = mclass.collect_accessible_mattributes(model_view) @@ -114,7 +108,6 @@ end private class NullableSends super Visitor - var modelbuilder: ModelBuilder var nclassdef: AClassdef var total_sends: Int = 0 @@ -122,13 +115,6 @@ private class NullableSends var nullable_eq_sends: Int = 0 var buggy_sends: Int = 0 - # Get a new visitor on a classef to add type count in `typecount`. - init(modelbuilder: ModelBuilder, nclassdef: AClassdef) - do - self.modelbuilder = modelbuilder - self.nclassdef = nclassdef - end - redef fun visit(n) do n.visit_all(self) @@ -168,7 +154,7 @@ do # Visit all the source code to collect data for nmodule in modelbuilder.nmodules do for nclassdef in nmodule.n_classdefs do - var visitor = new NullableSends(modelbuilder, nclassdef) + var visitor = new NullableSends(nclassdef) visitor.enter_visit(nclassdef) total_sends += visitor.total_sends nullable_sends += visitor.nullable_sends