X-Git-Url: http://nitlanguage.org diff --git a/src/syntax/mmbuilder.nit b/src/syntax/mmbuilder.nit index f9fb9d2..983bc8f 100644 --- a/src/syntax/mmbuilder.nit +++ b/src/syntax/mmbuilder.nit @@ -59,7 +59,7 @@ redef class MMSrcModule # Compute specialization relation for c in local_classes do - if visibility_for(c.global.intro.module) < c.global.visibility_level then + if visibility_for(c.global.intro.mmmodule) < c.global.visibility_level then continue end c.compute_super_classes @@ -84,18 +84,15 @@ redef class MMSrcModule end # Check class conformity - var mmbv1b = new ClassVerifierVisitor(tc, self) + var mmbv1c = new ClassVerifierVisitor(tc, self) for c in classes do - c.accept_class_visitor(mmbv1b) + c.accept_class_visitor(mmbv1c) end tc.check_errors # Property inhritance and introduction var mmbv2 = new PropertyBuilderVisitor(tc, self) for c in classes do - # Inherit global properties - c.inherit_global_properties - # Global property introduction and redefinition c.accept_class_visitor(mmbv2) @@ -114,14 +111,6 @@ redef class MMSrcModule c.accept_properties_visitor(mmbv3) end - # Check inherited local properties - for c in classes do - for g in c.global_properties do - if visibility_for(g.intro.module) < g.visibility_level then continue - var p = c[g] - end - end - tc.check_errors end @@ -469,11 +458,11 @@ redef class AModule end end -redef class APackagedecl +redef class AModuledecl redef fun accept_class_builder(v) do - if n_id.to_symbol != v.module.name then - v.error(n_id, "Error: Package name missmatch between {v.module.name} and {n_id.to_symbol}") + if n_id.to_symbol != v.mmmodule.name then + v.error(n_id, "Error: Module name missmatch between {v.mmmodule.name} and {n_id.to_symbol}") end end end @@ -536,7 +525,7 @@ redef class AClassdef redef fun accept_class_builder(v) do var local_class: MMSrcLocalClass - var mod = v.module + var mod = v.mmmodule var local_classes = mod.src_local_classes if (local_classes.has_key(name)) then local_class = local_classes[name] @@ -641,7 +630,7 @@ redef class AStdClassdef # Redef - glob.check_visibility(v, self, v.module) + glob.check_visibility(v, self, v.mmmodule) if n_kwredef == null then v.error(self, "Redef error: {name} is an imported class. Add the redef keyword to refine it.") return @@ -702,14 +691,14 @@ redef class AFormaldef var o = c.global.intro if c == o then if n_type == null then - _formal.bound = v.module.type_any.as_nullable + _formal.bound = v.mmmodule.type_any.as_nullable else var stype = n_type.get_stype(v) if stype == null then return _formal.bound = stype end else - var ob = o.get_formal(_formal.position).bound.for_module(v.module) + var ob = o.get_formal(_formal.position).bound.for_module(v.mmmodule) if n_type == null then _formal.bound = ob else @@ -819,7 +808,6 @@ redef class APropdef if s == null then if v.signature_builder.params.length != isig.arity then - #prop.node.printl("v.params.length {v.params.length} != isig.arity {isig.arity} ; {prop.full_name} vs {ip.full_name}") return end for p in v.signature_builder.params do @@ -854,7 +842,7 @@ redef class APropdef end var s = prop.signature - #print "process {prop.local_class.module}::{prop.local_class}::{prop} from global {prop.global.local_property.local_class.module}::{prop.global.local_property.local_class}::{prop.global.local_property}" + #print "process {prop.local_class.mmmodule}::{prop.local_class}::{prop} from global {prop.global.local_property.local_class.mmmodule}::{prop.global.local_property.local_class}::{prop.global.local_property}" for i in prop.prhe.direct_greaters do var ip = i.local_class[prop.global] var isig = i.signature.adaptation_to(v.local_class.get_type) @@ -893,9 +881,9 @@ redef class APropdef if s.arity != isig.arity then v.error(self, "Redef error: {prop.local_class}::{prop} redefines {ip.local_class}::{ip} with {isig.arity} parameter(s).") else - for i in [0..s.arity[ do - if s[i] != isig[i] then - v.error(self, "Redef error: Expected {isig[i]} (as in {ip.local_class}::{ip}), got {s[i]} in {prop.local_class}::{prop}.") + for j in [0..s.arity[ do + if s[j] != isig[j] then + v.error(self, "Redef error: Expected {isig[j]} (as in {ip.local_class}::{ip}), got {s[j]} in {prop.local_class}::{prop}.") end end end @@ -920,7 +908,7 @@ redef class APropdef if visibility_level != 1 and glob.visibility_level != visibility_level then v.error(self, "Redef error: {prop.local_class}::{prop} redefinition cannot change visibility.") end - glob.check_visibility(v, self, v.module, true) + glob.check_visibility(v, self, v.mmmodule, true) end end @@ -933,20 +921,33 @@ redef class AAttrPropdef redef fun accept_property_builder(v) do super - var name = n_id.to_symbol + var name: Symbol + if n_id != null then + name = n_id.to_symbol + else + name = ("@" + n_id2.text).to_symbol + end var lc = v.local_class var prop = new MMSrcAttribute(name, lc, self) _prop = prop v.local_class.add_src_local_property(v, prop) - if n_readable != null then - name = n_id.text.substring_from(1).to_symbol + if n_readable != null or n_id == null then + if n_id != null then + name = n_id.text.substring_from(1).to_symbol + else + name = n_id2.to_symbol + end var readmethod = new MMReadImplementationMethod(name, lc, self) _readmethod = readmethod v.local_class.add_src_local_property(v, readmethod) end - if n_writable != null then - name = (n_id.text.substring_from(1) + "=").to_symbol + if n_writable != null or n_id == null then + if n_id != null then + name = (n_id.text.substring_from(1) + "=").to_symbol + else + name = (n_id2.text + "=").to_symbol + end var writemethod = new MMWriteImplementationMethod(name, lc, self) _writemethod = writemethod v.local_class.add_src_local_property(v, writemethod) @@ -961,7 +962,7 @@ redef class AAttrPropdef var t0 = n_type.get_stype(v) if t0 != null then t = t0 else return else - v.error(self, "Not yet implemented: Attribute definition {_prop.local_class}::{_prop} requires an explicit type.") + v.error(self, "Not yet implemented: Attribute definition {prop.local_class}::{prop} requires an explicit type.") return end @@ -969,17 +970,21 @@ redef class AAttrPropdef var signature = new MMSignature(new Array[MMType], t, v.local_class.get_type) prop.signature = signature var visibility_level = n_visibility.level - process_and_check(v, prop, n_kwredef != null, visibility_level) - if n_readable != null then + process_and_check(v, prop, n_id != null and n_kwredef != null, visibility_level) + if n_readable != null or n_id == null then var m = _readmethod.as(not null) m.signature = signature - process_and_check(v, m, n_readable.n_kwredef != null, visibility_level) + process_and_check(v, m, (n_readable != null and n_readable.n_kwredef != null) or (n_id == null and n_kwredef != null), visibility_level) n_type.check_visibility(v, m) end - if n_writable != null then + if n_writable != null or n_id == null then var m = _writemethod.as(not null) m.signature = new MMSignature(new Array[MMType].with_items(t), null, v.local_class.get_type) - process_and_check(v, m, n_writable.n_kwredef != null, visibility_level) + var vl = visibility_level + if n_id == null then + if n_writable == null then vl = 3 else vl = n_writable.n_visibility.level # write accessor has a specific visibility + end + process_and_check(v, m, n_writable != null and n_writable.n_kwredef != null, vl) n_type.check_visibility(v, m) end end @@ -1062,6 +1067,21 @@ redef class AMainMethPropdef end end +redef class AExternMethPropdef + redef fun accept_property_verifier(v) + do + super # Compute signature + var ename: String + if n_extern != null then + ename = n_extern.text + ename = ename.substring(1, ename.length-2) + else + ename = "{method.mmmodule.name}_{method.local_class.name}_{method.local_class.name}_{method.name}_{method.signature.arity}" + end + method.extern_name = ename + end +end + redef class ATypePropdef redef fun prop do return _prop.as(not null) var _prop: nullable MMSrcTypeProperty @@ -1177,7 +1197,7 @@ redef class AParam do super _position = v.signature_builder.params.length - _variable = new ParamVariable(n_id.to_symbol, self) + _variable = new ParamVariable(n_id.to_symbol, n_id) v.signature_builder.params.add(self) v.signature_builder.untyped_params.add(self) if n_type != null then @@ -1228,15 +1248,22 @@ redef class AClosureDecl end # Add the finalizer to the closure signature - var finalize_sig = new MMSignature(new Array[MMType], null, v.module.type_any) # FIXME should be no receiver - var finalizer_clos = new MMClosure(finalize_sig, false, true) + var finalize_sig = new MMSignature(new Array[MMType], null, v.mmmodule.type_any) # FIXME should be no receiver + var finalizer_clos = new MMClosure(once ("break".to_symbol), finalize_sig, false, true) sig.closures.add(finalizer_clos) - var clos = new MMClosure(sig, n_kwbreak != null, n_expr != null) + var name = n_id.to_symbol + var clos = new MMClosure(name, sig, n_kwbreak != null, n_expr != null) + for c in old_signature_builder.closure_decls do + if c.n_id.to_symbol == name then + v.error(n_id, "A closure '!{name}' already defined at {c.n_id.location.relative_to(n_id.location)}.") + return + end + end v.signature_builder = old_signature_builder _position = old_signature_builder.closure_decls.length old_signature_builder.closure_decls.add(self) - _variable = new ClosureVariable(n_id.to_symbol, self, clos) + _variable = new ClosureVariable(n_id.to_symbol, n_id, clos) end end