X-Git-Url: http://nitlanguage.org diff --git a/contrib/nitcc/src/grammar.nit b/contrib/nitcc/src/grammar.nit index b9ac2f8..0a10beb 100644 --- a/contrib/nitcc/src/grammar.nit +++ b/contrib/nitcc/src/grammar.nit @@ -575,7 +575,7 @@ class LRAutomaton # Generate a graphviz file of the automaton fun to_dot(path: String) do - var f = new OFStream.open(path) + var f = new FileWriter.open(path) f.write("digraph g \{\n") f.write("rankdir=LR;\n") f.write("node[shape=Mrecord,height=0];\n") @@ -622,7 +622,7 @@ class LRAutomaton do var gen = new Generator gen.gen_to_nit(self, name) - var f = new OFStream.open(filepath) + var f = new FileWriter.open(filepath) for s in gen.out do f.write(s) f.write("\n") @@ -648,14 +648,12 @@ private class Generator add "\tredef fun start_state do return state_{states.first.cname}" add "end" - add "redef class Object" for s in states do - add "\tprivate fun state_{s.cname}: LRState{s.cname} do return once new LRState{s.cname}" + add "private fun state_{s.cname}: LRState{s.cname} do return once new LRState{s.cname}" end for p in gram.prods do - add "\tprivate fun goto_{p.cname}: Goto_{p.cname} do return once new Goto_{p.cname}" + add "private fun goto_{p.cname}: Goto_{p.cname} do return once new Goto_{p.cname}" end - add "end" add "redef class NToken" for s in states do @@ -997,6 +995,8 @@ class LRState abort end end + # Token to remove as reduction guard to solve S/R conflicts + var removed_reduces = new Array[Token] for t, a in guarded_reduce do if a.length > 1 then print "REDUCE/REDUCE Conflict on state {self.number} {self.name} for token {t}:" @@ -1033,14 +1033,18 @@ class LRState print "Automatic Dangling on state {self.number} {self.name} for token {t}:" print "\treduce: {ri}" for r in ress do print r - guarded_reduce.keys.remove(t) + removed_reduces.add t else print "SHIFT/REDUCE Conflict on state {self.number} {self.name} for token {t}:" print "\treduce: {ri}" for i in guarded_shift[t] do print "\tshift: {i}" + removed_reduces.add t end end end + for t in removed_reduces do + guarded_reduce.keys.remove(t) + end end # Return `i` and all other items of the state that expands, directly or indirectly, to `i`