X-Git-Url: http://nitlanguage.org diff --git a/src/modelize/modelize_class.nit b/src/modelize/modelize_class.nit index 14c8e94..853d8ff 100644 --- a/src/modelize/modelize_class.nit +++ b/src/modelize/modelize_class.nit @@ -46,8 +46,11 @@ redef class ModelBuilder var mvisibility: nullable MVisibility var arity = 0 var names = new Array[String] + var mclass if nclassdef isa AStdClassdef then - name = nclassdef.n_id.text + var qid = nclassdef.n_qid + assert qid != null + name = qid.n_id.text nkind = nclassdef.n_classkind mkind = nkind.mkind nvisibility = nclassdef.n_visibility @@ -74,6 +77,12 @@ redef class ModelBuilder end names.add(ptname) end + mclass = try_get_mclass_by_qid(qid, mmodule) + if mclass == null and (qid.n_qualified != null or nclassdef.n_kwredef != null) then + class_not_found(qid, mmodule) + nclassdef.is_broken = true + return + end else if nclassdef isa ATopClassdef and nclassdef.n_propdefs.first.as(AMethPropdef).n_methid.collect_text == "sys" then # Special case to keep `sys` in object. @@ -84,21 +93,17 @@ redef class ModelBuilder mkind = interface_kind nvisibility = null mvisibility = public_visibility + mclass = try_get_mclass_by_name(nclassdef, mmodule, name) else name = "Sys" nkind = null mkind = concrete_kind nvisibility = null mvisibility = public_visibility + mclass = try_get_mclass_by_name(nclassdef, mmodule, name) end - var mclass = try_get_mclass_by_name(nclassdef, mmodule, name) if mclass == null then - if nclassdef isa AStdClassdef and nclassdef.n_kwredef != null then - error(nclassdef, "Redef Error: no imported class `{name}` to refine.") - return - end - # Check for conflicting class full-names in the package if mmodule.mgroup != null and mvisibility >= protected_visibility then var mclasses = model.get_mclasses_by_name(name) @@ -112,16 +117,19 @@ redef class ModelBuilder end end - mclass = new MClass(mmodule, name, names, mkind, mvisibility) + mclass = new MClass(mmodule, name, nclassdef.location, names, mkind, mvisibility) #print "new class {mclass}" else if nclassdef isa AStdClassdef and nmodule.mclass2nclassdef.has_key(mclass) then error(nclassdef, "Error: a class `{name}` is already defined at line {nmodule.mclass2nclassdef[mclass].location.line_start}.") + mclass.is_broken = true return else if nclassdef isa AStdClassdef and nclassdef.n_kwredef == null then error(nclassdef, "Redef Error: `{name}` is an imported class. Add the `redef` keyword to refine it.") + mclass.is_broken = true return else if arity != 0 and mclass.arity != arity then error(nclassdef, "Redef Error: expected {mclass.arity} formal parameter(s) for {mclass.signature_to_s}; got {arity}.") + mclass.is_broken = true return else if nkind != null and mkind != concrete_kind and mclass.kind != mkind then error(nkind, "Redef Error: refinement changed the kind from `{mclass.kind}` to `{mkind}`.") @@ -141,7 +149,6 @@ redef class ModelBuilder private fun build_a_mclassdef(nmodule: AModule, nclassdef: AClassdef) do var mmodule = nmodule.mmodule.as(not null) - var objectclass = try_get_mclass_by_name(nmodule, mmodule, "Object") var mclass = nclassdef.mclass if mclass == null then return # Skip error @@ -153,8 +160,45 @@ redef class ModelBuilder return end + var bound_mtype = build_a_bound_mtype(nmodule, nclassdef) + if bound_mtype == null then return + var mclassdef = new MClassDef(mmodule, bound_mtype, nclassdef.location) + nclassdef.mclassdef = mclassdef + self.mclassdef2nclassdef[mclassdef] = nclassdef + + if nclassdef isa AStdClassdef then + var ndoc = nclassdef.n_doc + if ndoc != null then + var mdoc = ndoc.to_mdoc + mclassdef.mdoc = mdoc + mdoc.original_mentity = mclassdef + else if mclassdef.is_intro and mclass.visibility >= public_visibility then + advice(nclassdef, "missing-doc", "Documentation warning: Undocumented public class `{mclass}`") + end + end + + if mclassdef.is_intro then + self.toolcontext.info("{mclassdef} introduces new {mclass.kind} {mclass.full_name}", 3) + else + self.toolcontext.info("{mclassdef} refines {mclass.kind} {mclass.full_name}", 3) + end + end + + # Determine the type parameter bounds for `nclassdef`. + # + # In case of error, return `null`. + # + # REQUIRE: `nmodule.mmodule != null` + # REQUIRE: `nclassdef.mclass != null` + private fun build_a_bound_mtype(nmodule: AModule, nclassdef: AClassdef): nullable MClassType + do + var mmodule = nmodule.mmodule.as(not null) + var mclass = nclassdef.mclass.as(not null) + var bounds = new Array[MType] if nclassdef isa AStdClassdef and mclass.arity > 0 then + var objectclass = try_get_mclass_by_name(nmodule, mmodule, "Object") + # Revolve bound for formal parameters for i in [0..mclass.arity[ do if nclassdef.n_formaldefs.is_empty then @@ -171,8 +215,8 @@ redef class ModelBuilder end var nfdt = nfd.n_type if nfdt != null then - var bound = resolve_mtype_unchecked(mmodule, null, nfdt, false) - if bound == null then return # Forward error + var bound = resolve_mtype3_unchecked(mmodule, null, null, nfdt, false) + if bound == null then return null # Forward error if bound.need_anchor then # No F-bounds! error(nfd, "Error: formal parameter type `{pname}` bounded with a formal parameter type.") @@ -180,13 +224,10 @@ redef class ModelBuilder bounds.add(bound) nfd.bound = bound end - if bound isa MClassType and bound.mclass.kind == enum_kind then - warning(nfdt, "useless-bound", "Warning: useless formal parameter type since `{bound}` cannot have subclasses.") - end else if mclass.mclassdefs.is_empty then if objectclass == null then error(nfd, "Error: formal parameter type `{pname}` unbounded but no `Object` class exists.") - return + return null end # No bound, then implicitely bound by nullable Object var bound = objectclass.mclass_type.as_nullable @@ -201,41 +242,39 @@ redef class ModelBuilder end end - var bound_mtype = mclass.get_mtype(bounds) - var mclassdef = new MClassDef(mmodule, bound_mtype, nclassdef.location) - nclassdef.mclassdef = mclassdef - self.mclassdef2nclassdef[mclassdef] = nclassdef - - if nclassdef isa AStdClassdef then - var ndoc = nclassdef.n_doc - if ndoc != null then - var mdoc = ndoc.to_mdoc - mclassdef.mdoc = mdoc - mdoc.original_mentity = mclassdef - else if mclassdef.is_intro and mclass.visibility >= public_visibility then - advice(nclassdef, "missing-doc", "Documentation warning: Undocumented public class `{mclass}`") - end - end - - if mclassdef.is_intro then - self.toolcontext.info("{mclassdef} introduces new {mclass.kind} {mclass.full_name}", 3) - else - self.toolcontext.info("{mclassdef} refine {mclass.kind} {mclass.full_name}", 3) - end + return mclass.get_mtype(bounds) end # Visit the AST and set the super-types of the `MClassDef` objects - private fun collect_a_mclassdef_inheritance(nmodule: AModule, nclassdef: AClassdef) + private fun build_a_mclassdef_inheritance(nmodule: AModule, nclassdef: AClassdef) do var mmodule = nmodule.mmodule if mmodule == null then return - var objectclass = try_get_mclass_by_name(nmodule, mmodule, "Object") - var pointerclass = try_get_mclass_by_name(nmodule, mmodule, "Pointer") var mclass = nclassdef.mclass if mclass == null then return var mclassdef = nclassdef.mclassdef if mclassdef == null then return + var supertypes = collect_supertypes(nmodule, nclassdef, mclassdef.is_intro) + mclassdef.set_supertypes(supertypes) + if not supertypes.is_empty then self.toolcontext.info("{mclassdef} new super-types: {supertypes.join(", ")}", 3) + end + + # List the supertypes specified or implied by `nclassdef`. + # + # REQUIRE: `nmodule.mmodule != null` + # REQUIRE: `nclassdef.mclass != null` + private fun collect_supertypes(nmodule: AModule, nclassdef: AClassdef, + is_intro: Bool): Array[MClassType] + do + var mmodule = nmodule.mmodule.as(not null) + var mclass = nclassdef.mclass.as(not null) + var name = mclass.name + var kind = mclass.kind + + var objectclass = try_get_mclass_by_name(nmodule, mmodule, "Object") + var pointerclass = try_get_mclass_by_name(nmodule, mmodule, "Pointer") + # Do we need to specify Object as a super class? var specobject = true @@ -248,33 +287,43 @@ redef class ModelBuilder for nsc in nclassdef.n_superclasses do specobject = false var ntype = nsc.n_type - var mtype = resolve_mtype_unchecked(mmodule, mclassdef, ntype, false) + var mtype = resolve_mtype3_unchecked(mmodule, mclass, null, + ntype, false) if mtype == null then continue # Skip because of error if not mtype isa MClassType then - error(ntype, "Error: supertypes cannot be a formal type.") - return + error(ntype, "Error: a supertype cannot be a formal type.") + continue end - if not mclass.kind.can_specialize(mtype.mclass.kind) then - error(ntype, "Error: {mclass.kind} `{mclass}` cannot specialize {mtype.mclass.kind} `{mtype.mclass}`.") + var superclass = mtype.mclass + var super_kind = superclass.kind + if not kind.can_specialize(super_kind) then + error(ntype, "Error: {kind} `{mclass}` cannot specialize {super_kind} `{superclass}`.") end supertypes.add mtype #print "new super : {mclass} < {mtype}" - if mtype.mclass.kind == extern_kind then specpointer = false + if super_kind == extern_kind then specpointer = false end end - if mclassdef.is_intro and objectclass != null then - if mclass.kind == extern_kind and mclass.name != "Pointer" then + if is_intro and objectclass != null then + if kind == extern_kind and name != "Pointer" then # it is an extern class, but not a Pointer + if pointerclass == null then + error(nclassdef, "Error: `Pointer` must be defined first.") + return supertypes + end if specpointer then supertypes.add pointerclass.mclass_type - else if specobject and mclass.name != "Object" then - # it is a standard class without super class (but is not Object) - supertypes.add objectclass.mclass_type + else if specobject then + if name != "Object" then + # it is a standard class without super class (but is not Object) + supertypes.add objectclass.mclass_type + else if kind != interface_kind then + error(nclassdef, "Error: `Object` must be an {interface_kind}.") + end end end - mclassdef.set_supertypes(supertypes) - if not supertypes.is_empty then self.toolcontext.info("{mclassdef} new super-types: {supertypes.join(", ")}", 3) + return supertypes end # Check the validity of the specialization heirarchy @@ -295,10 +344,8 @@ redef class ModelBuilder end # Build the classes of the module `nmodule`. - # REQUIRE: classes of imported modules are already build. (let `phase` do the job) private fun build_classes(nmodule: AModule) do - var errcount = toolcontext.error_count # Force building recursively if nmodule.build_classes_is_done then return nmodule.build_classes_is_done = true @@ -309,8 +356,6 @@ redef class ModelBuilder if nimp != null then build_classes(nimp) end - if errcount != toolcontext.error_count then return - # Create all classes # process AStdClassdef before so that non-AStdClassdef classes can be attached to existing ones, if any for nclassdef in nmodule.n_classdefs do @@ -322,8 +367,6 @@ redef class ModelBuilder self.build_a_mclass(nmodule, nclassdef) end - if errcount != toolcontext.error_count then return - # Create all classdefs for nclassdef in nmodule.n_classdefs do if not nclassdef isa AStdClassdef then continue @@ -334,38 +377,40 @@ redef class ModelBuilder self.build_a_mclassdef(nmodule, nclassdef) end - if errcount != toolcontext.error_count then return - # Create inheritance on all classdefs for nclassdef in nmodule.n_classdefs do - self.collect_a_mclassdef_inheritance(nmodule, nclassdef) + self.build_a_mclassdef_inheritance(nmodule, nclassdef) end - if errcount != toolcontext.error_count then return - # Create the mclassdef hierarchy for mclassdef in mmodule.mclassdefs do mclassdef.add_in_hierarchy end - if errcount != toolcontext.error_count then return - # Check inheritance for nclassdef in nmodule.n_classdefs do self.check_supertypes(nmodule, nclassdef) end - if errcount != toolcontext.error_count then return - # Check unchecked ntypes for nclassdef in nmodule.n_classdefs do if nclassdef isa AStdClassdef then var mclassdef = nclassdef.mclassdef + var mclass + var anchor + if mclassdef == null then + mclass = null + anchor = null + else + mclass = mclassdef.mclass + anchor = mclassdef.bound_mtype + end + # check bound of formal parameter - for nfd in nclassdef.n_formaldefs do + for nfd in nclassdef.n_formaldefs do var nfdt = nfd.n_type if nfdt != null and nfdt.mtype != null then - var bound = resolve_mtype(mmodule, mclassdef, nfdt) + var bound = resolve_mtype3(mmodule, mclass, anchor, nfdt) if bound == null then return # Forward error end end @@ -373,15 +418,13 @@ redef class ModelBuilder for nsc in nclassdef.n_superclasses do var ntype = nsc.n_type if ntype.mtype != null then - var mtype = resolve_mtype(mmodule, mclassdef, ntype) + var mtype = resolve_mtype3(mmodule, mclass, anchor, ntype) if mtype == null then return # Forward error end end end end - if errcount != toolcontext.error_count then return - # Check clash of ancestors for nclassdef in nmodule.n_classdefs do var mclassdef = nclassdef.mclassdef @@ -402,13 +445,11 @@ redef class ModelBuilder end end - if errcount != toolcontext.error_count then return - # TODO: Check that the super-class is not intrusive # Check that the superclasses are not already known (by transitivity) for nclassdef in nmodule.n_classdefs do - if not nclassdef isa AStdClassdef then continue + if not nclassdef isa AStdClassdef or nclassdef.is_broken then continue var mclassdef = nclassdef.mclassdef if mclassdef == null then continue @@ -429,8 +470,11 @@ redef class ModelBuilder for nsc in nclassdef.n_superclasses do var ntype = nsc.n_type var mtype = ntype.mtype - if mtype == null then continue - assert mtype isa MClassType + + # If the supertype is `null` or don’t refer to a class, we + # already raised an error. + if not mtype isa MClassType then continue + var sc = mtype.mclass if not parents.has(sc) or sc == objectclass then # Skip the warning on generated code @@ -494,6 +538,9 @@ end redef class AExternClasskind redef fun mkind do return extern_kind end +redef class ASubsetClasskind + redef fun mkind do return subset_kind +end redef class AFormaldef # The associated parameter type