From: Jean Privat <jean@pryen.org>
Date: Thu, 27 Nov 2014 20:30:01 +0000 (-0500)
Subject: typing: warn `useless-type` for useless type in a local variable
X-Git-Tag: v0.6.11~4^2~1
X-Git-Url: http://nitlanguage.org

typing: warn `useless-type` for useless type in a local variable

Signed-off-by: Jean Privat <jean@pryen.org>
---

diff --git a/src/semantize/typing.nit b/src/semantize/typing.nit
index 3140de5..cdb8ae8 100644
--- a/src/semantize/typing.nit
+++ b/src/semantize/typing.nit
@@ -668,7 +668,11 @@ redef class AVardeclExpr
 		var nexpr = self.n_expr
 		if nexpr != null then
 			if mtype != null then
-				v.visit_expr_subtype(nexpr, mtype)
+				var etype = v.visit_expr_subtype(nexpr, mtype)
+				if etype == mtype then
+					assert ntype != null
+					v.modelbuilder.advice(ntype, "useless-type", "Warning: useless type definition for variable `{variable.name}`")
+				end
 			else
 				mtype = v.visit_expr(nexpr)
 				if mtype == null then return # Skip error