From: Alexis Laferrière Date: Tue, 12 Jan 2016 04:00:59 +0000 (-0500) Subject: lib/core: remove support for ',' in `is_numeric` X-Git-Tag: v0.8~16^2~1 X-Git-Url: http://nitlanguage.org lib/core: remove support for ',' in `is_numeric` Signed-off-by: Alexis Laferrière --- diff --git a/lib/core/text/abstract_text.nit b/lib/core/text/abstract_text.nit index 401f32c..4770977 100644 --- a/lib/core/text/abstract_text.nit +++ b/lib/core/text/abstract_text.nit @@ -310,19 +310,18 @@ abstract class Text # assert "123".is_numeric == true # assert "1.2".is_numeric == true # assert "-1.2".is_numeric == true - # assert "1,2".is_numeric == true # assert "-1.23e-2".is_numeric == true # assert "1..2".is_numeric == false # assert "".is_numeric == false fun is_numeric: Bool do - var has_point_or_comma = false + var has_point = false var e_index = -1 for i in [0..length[ do var c = chars[i] if not c.is_numeric then - if (c == '.' or c == ',') and not has_point_or_comma then - has_point_or_comma = true + if c == '.' and not has_point then + has_point = true else if c == 'e' and e_index == -1 and i > 0 and i < length - 1 and chars[i-1] != '-' then e_index = i else if c == '-' and i == e_index + 1 and i < length - 1 then