nit.git
6 years agoMerge: lib/markdown: fix `text` for nested markdown blocks
Jean Privat [Tue, 17 Oct 2017 20:09:23 +0000 (16:09 -0400)]
Merge: lib/markdown: fix `text` for nested markdown blocks

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

Pull-Request: #2565

6 years agolib/markdown: fix `text` for nested markdown blocks
Alexandre Terrasa [Thu, 12 Oct 2017 00:46:11 +0000 (20:46 -0400)]
lib/markdown: fix `text` for nested markdown blocks

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agoMerge: model_collect: collect more things
Jean Privat [Tue, 10 Oct 2017 16:52:04 +0000 (12:52 -0400)]
Merge: model_collect: collect more things

A lot of new shortcuts.

Pull-Request: #2560

6 years agoMerge: model: is_accessor
Jean Privat [Tue, 10 Oct 2017 16:52:03 +0000 (12:52 -0400)]
Merge: model: is_accessor

Add a way to associate attributes and their getters/setters.

This will be useful for filtering things and groupings properties together.

Pull-Request: #2559

6 years agoMerge: Vector Space Model
Jean Privat [Tue, 10 Oct 2017 16:52:01 +0000 (12:52 -0400)]
Merge: Vector Space Model

# Vector Space Model

Vector Space Model (VSM) is an algebraic model for representing text documents
(and any objects, in general) as vectors of identifiers, such as, for example,
index terms.

It is used in information filtering, information retrieval, indexing and
relevancy rankings.

The `vsm` package provides the following features:
* Vector comparison with cosine similarity.
* Vector indexing and matching with tf * idf.
* File indexing and matching to free text queries.

## Vectors

With VSM, documents are represented by a n-dimensions vector.
Each dimension represent an attribute of the document or object.

For text document, the count of each term found in the document if often used to
build vectors.

### Creating a vector

~~~nit
var vector = new Vector
vector["term1"] = 2.0
vector["term2"] = 1.0
assert vector["term1"] == 2.0
assert vector["term2"] == 1.0
assert vector.norm.is_approx(2.236, 0.001)
~~~

### Comparing vectors

~~~nit
var v1 = new Vector
v1["term1"] = 1.0
v1["term2"] = 2.0

var v2 = new Vector
v2["term2"] = 1.0
v2["term3"] = 3.0

var query = new Vector
query["term2"] = 1.0

var s1 = query.cosine_similarity(v1)
var s2 = query.cosine_similarity(v2)
assert s1 > s2
~~~

## VSMIndex

VSMIndex is a Document index based on VSM.

Using VSMIndex you can index documents associated with their vector.
Documents can then be matched to query vectors.

This represents a minimalistic search engine.

~~~nit
var index = new VSMIndex

var d1 = new Document("Doc 1", "/uri/1", v1)
index.index_document(d1)

var d2 = new Document("Doc 2", "/uri/2", v2)
index.index_document(d2)

assert index.documents.length == 2

query = new Vector
query["term1"] = 1.0

var matches = index.match_vector(query)
assert matches.first.document == d1
~~~

## StringIndex

The StringIndex provides usefull services to index and match strings.

~~~nit
index = new StringIndex

d1 = index.index_string("Doc 1", "/uri/1", "this is a sample")
d2 = index.index_string("Doc 2", "/uri/2", "this and this is another example")
assert index.documents.length == 2

matches = index.match_string("this sample")
assert matches.first.document == d1
~~~

## FileIndex

The FileIndex is a StringIndex able to index and retrieve files.

~~~nit
index = new FileIndex

index.index_files(["/path/to/doc/1", "/path/to/doc/2"])
~~~

Pull-Request: #2556
Reviewed-by: Jean Privat <jean@pryen.org>

6 years agonlp: use new vector representation
Alexandre Terrasa [Fri, 6 Oct 2017 17:46:36 +0000 (13:46 -0400)]
nlp: use new vector representation

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitweb: use model_collect for definitions lists
Alexandre Terrasa [Fri, 29 Sep 2017 21:32:16 +0000 (17:32 -0400)]
nitweb: use model_collect for definitions lists

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agomodel_collect: collect more things
Alexandre Terrasa [Fri, 29 Sep 2017 21:31:58 +0000 (17:31 -0400)]
model_collect: collect more things

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agomodel_collect: uniformize documentation
Alexandre Terrasa [Fri, 29 Sep 2017 21:05:48 +0000 (17:05 -0400)]
model_collect: uniformize documentation

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agotests: update tests for vsm
Alexandre Terrasa [Fri, 29 Sep 2017 19:13:23 +0000 (15:13 -0400)]
tests: update tests for vsm

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agolib/vsm: add README
Alexandre Terrasa [Wed, 27 Sep 2017 02:42:39 +0000 (22:42 -0400)]
lib/vsm: add README

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agolib/vsm: introduce an indexing process based on VSM
Alexandre Terrasa [Fri, 22 Sep 2017 20:37:19 +0000 (16:37 -0400)]
lib/vsm: introduce an indexing process based on VSM

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agolib/vsm: accept anything as a dimension
Alexandre Terrasa [Wed, 20 Sep 2017 22:23:40 +0000 (18:23 -0400)]
lib/vsm: accept anything as a dimension

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agolib/nlp: move vsm.nit to its own package
Alexandre Terrasa [Wed, 20 Sep 2017 22:23:09 +0000 (18:23 -0400)]
lib/nlp: move vsm.nit to its own package

We don't need nlp to use vsm

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agomodel: remove a warning :p
Alexandre Terrasa [Fri, 29 Sep 2017 18:46:04 +0000 (14:46 -0400)]
model: remove a warning :p

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agomodelize: define attribute getters and setters
Alexandre Terrasa [Fri, 29 Sep 2017 18:45:54 +0000 (14:45 -0400)]
modelize: define attribute getters and setters

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agomodel: tag getters and setters
Alexandre Terrasa [Fri, 29 Sep 2017 18:45:34 +0000 (14:45 -0400)]
model: tag getters and setters

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agoMerge: lib: introduce `fca` a module for formal concept analysis
Jean Privat [Thu, 28 Sep 2017 23:39:24 +0000 (19:39 -0400)]
Merge: lib: introduce `fca` a module for formal concept analysis

## Building a FormalContext

We use the example from https://en.wikipedia.org/wiki/Formal_concept_analysis:

~~~nit
var fc = new FormalContext[Int, String]
fc.set_object_attributes(1, ["odd", "square"])
fc.set_object_attributes(2, ["even", "prime"])
fc.set_object_attributes(3, ["odd", "prime"])
fc.set_object_attributes(4, ["even", "composite", "square"])
fc.set_object_attributes(5, ["odd", "prime"])
fc.set_object_attributes(6, ["even", "composite"])
fc.set_object_attributes(7, ["odd", "prime"])
fc.set_object_attributes(8, ["even", "composite"])
fc.set_object_attributes(9, ["odd", "square", "composite"])
fc.set_object_attributes(10, ["even", "composite"])
~~~

## Computing the set of FormalConcept

~~~nit
var concepts = fc.formal_concepts
for concept in concepts do
print concept
end
~~~

## Visualizing formal concept with ConceptLattice

~~~nit
var cl = new ConceptLattice[Int, String].from_concepts(concepts)
cl.show_dot
~~~

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

Pull-Request: #2557
Reviewed-by: Jean Privat <jean@pryen.org>

6 years agoMerge: .gitignore: ignore more vim files
Jean Privat [Thu, 28 Sep 2017 23:39:23 +0000 (19:39 -0400)]
Merge: .gitignore: ignore more vim files

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

Pull-Request: #2555

6 years agoMerge: model_visitor: reject is_before and is_after as they are tests
Jean Privat [Thu, 28 Sep 2017 23:39:22 +0000 (19:39 -0400)]
Merge: model_visitor: reject is_before and is_after as they are tests

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

Pull-Request: #2554

6 years agoMerge: doc_commands: parse parameters
Jean Privat [Thu, 28 Sep 2017 23:39:22 +0000 (19:39 -0400)]
Merge: doc_commands: parse parameters

This PR allows the user of doc cards to pass parameters through the card declaration:

* `command: arg | option1: value1, option2: value2`

It can be used in a doc command so one can write:

~~~
Here a graph:
[[graph: core::Array | cdepth: 1, pdepth: 4]]
~~~

Pull-Request: #2553
Reviewed-by: Jean Privat <jean@pryen.org>

6 years agoMerge: nitweb: fully integrate catalog
Jean Privat [Thu, 28 Sep 2017 23:39:21 +0000 (19:39 -0400)]
Merge: nitweb: fully integrate catalog

Some work to integrate the nit catalog with nitweb:
* make the catalog API more usable
* serves the catalog API through JSON/REST
* integrate with current frontend

New features:
* catalog integration
* new search process and ui
* pagination for results and catalog (faster!)
* cards cleaning
* tabs cleaning

Demo: DIY

Pull-Request: #2552

6 years agolib: introduce `fca` a module for formal concept analysis
Alexandre Terrasa [Thu, 28 Sep 2017 23:31:48 +0000 (19:31 -0400)]
lib: introduce `fca` a module for formal concept analysis

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitweb: allow options in graph card
Alexandre Terrasa [Tue, 26 Sep 2017 20:25:45 +0000 (16:25 -0400)]
nitweb: allow options in graph card

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agosrc/doc_down: fix `comment` behavior
Alexandre Terrasa [Tue, 29 Aug 2017 23:52:54 +0000 (19:52 -0400)]
src/doc_down: fix `comment` behavior

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agosrc/doc_commands: merge Article and Comment commands
Alexandre Terrasa [Tue, 29 Aug 2017 23:52:35 +0000 (19:52 -0400)]
src/doc_commands: merge Article and Comment commands

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years ago.gitignore: ignore more vim files
Alexandre Terrasa [Fri, 22 Sep 2017 20:40:17 +0000 (16:40 -0400)]
.gitignore: ignore more vim files

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agomodel_visitor: reject is_before and is_after as they are tests
Alexandre Terrasa [Tue, 26 Sep 2017 20:46:44 +0000 (16:46 -0400)]
model_visitor: reject is_before and is_after as they are tests

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitweb: use new doc commands parser
Alexandre Terrasa [Tue, 29 Aug 2017 23:32:12 +0000 (19:32 -0400)]
nitweb: use new doc commands parser

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitdoc: use new doc commands parser
Alexandre Terrasa [Tue, 29 Aug 2017 23:31:59 +0000 (19:31 -0400)]
nitdoc: use new doc commands parser

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitdoc: remove warnings from doc_readme
Alexandre Terrasa [Tue, 29 Aug 2017 22:27:23 +0000 (18:27 -0400)]
nitdoc: remove warnings from doc_readme

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitx: update to doc commands parser
Alexandre Terrasa [Tue, 29 Aug 2017 22:22:29 +0000 (18:22 -0400)]
nitx: update to doc commands parser

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agosrc/doc_commands: rewrite doc commands parser
Alexandre Terrasa [Tue, 29 Aug 2017 22:22:15 +0000 (18:22 -0400)]
src/doc_commands: rewrite doc commands parser

Also add tests

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitweb: rewrite search ui
Alexandre Terrasa [Wed, 16 Aug 2017 23:18:55 +0000 (19:18 -0400)]
nitweb: rewrite search ui

Display a new menu that allows the user to jump on a result page.

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitweb: catalog refine search algorithm
Alexandre Terrasa [Wed, 16 Aug 2017 23:17:05 +0000 (19:17 -0400)]
nitweb: catalog refine search algorithm

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitweb: remove useless catalog handlers
Alexandre Terrasa [Wed, 16 Aug 2017 21:29:02 +0000 (17:29 -0400)]
nitweb: remove useless catalog handlers

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitweb: add catalog sidebar on package views
Alexandre Terrasa [Tue, 15 Aug 2017 22:13:07 +0000 (18:13 -0400)]
nitweb: add catalog sidebar on package views

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitweb: rewrite catalog frontend
Alexandre Terrasa [Tue, 15 Aug 2017 20:55:32 +0000 (16:55 -0400)]
nitweb: rewrite catalog frontend

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitweb: remove tabs from cards
Alexandre Terrasa [Wed, 16 Aug 2017 21:32:14 +0000 (17:32 -0400)]
nitweb: remove tabs from cards

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitweb: move grades frontend from card to tab
Alexandre Terrasa [Tue, 15 Aug 2017 23:40:33 +0000 (19:40 -0400)]
nitweb: move grades frontend from card to tab

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitweb: rename frontend module `index` in `catalog`
Alexandre Terrasa [Tue, 15 Aug 2017 20:44:00 +0000 (16:44 -0400)]
nitweb: rename frontend module `index` in `catalog`

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitweb: frontend add ui-pagination directive
Alexandre Terrasa [Tue, 15 Aug 2017 20:59:06 +0000 (16:59 -0400)]
nitweb: frontend add ui-pagination directive

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitweb: catalog api serves persons related data
Alexandre Terrasa [Tue, 15 Aug 2017 20:51:09 +0000 (16:51 -0400)]
nitweb: catalog api serves persons related data

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitweb: catalog api serves tags related data
Alexandre Terrasa [Tue, 15 Aug 2017 20:50:51 +0000 (16:50 -0400)]
nitweb: catalog api serves tags related data

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitweb: catalog api use mpackage_stats
Alexandre Terrasa [Tue, 15 Aug 2017 20:48:59 +0000 (16:48 -0400)]
nitweb: catalog api use mpackage_stats

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitweb: introduce /api/catalog/packages route
Alexandre Terrasa [Tue, 15 Aug 2017 20:35:21 +0000 (16:35 -0400)]
nitweb: introduce /api/catalog/packages route

List all packages in current catalog

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitweb: introduce custom serialization for CatalogHandler
Alexandre Terrasa [Tue, 15 Aug 2017 20:33:56 +0000 (16:33 -0400)]
nitweb: introduce custom serialization for CatalogHandler

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitweb: move catalog building to Catalog redef
Alexandre Terrasa [Tue, 15 Aug 2017 20:32:38 +0000 (16:32 -0400)]
nitweb: move catalog building to Catalog redef

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitweb: rewrite catalog serialization
Alexandre Terrasa [Tue, 15 Aug 2017 20:30:35 +0000 (16:30 -0400)]
nitweb: rewrite catalog serialization

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agonitweb: introduce pagination handler
Alexandre Terrasa [Tue, 15 Aug 2017 19:52:04 +0000 (15:52 -0400)]
nitweb: introduce pagination handler

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agocatalog: introduce some sorters
Alexandre Terrasa [Tue, 15 Aug 2017 20:25:02 +0000 (16:25 -0400)]
catalog: introduce some sorters

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agocatalog: introduce CatalogStats to retrieve all the stats of the catalog
Alexandre Terrasa [Tue, 15 Aug 2017 20:24:50 +0000 (16:24 -0400)]
catalog: introduce CatalogStats to retrieve all the stats of the catalog

Useful for serialization

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agocatalog: introduce MPackageStats to retrieve the stats of a MPackage
Alexandre Terrasa [Tue, 15 Aug 2017 20:24:09 +0000 (16:24 -0400)]
catalog: introduce MPackageStats to retrieve the stats of a MPackage

Usefull for serialization

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agocatalog: associate persons to their short name
Alexandre Terrasa [Tue, 15 Aug 2017 20:09:17 +0000 (16:09 -0400)]
catalog: associate persons to their short name

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agocatalog: associate packages to their full_name
Alexandre Terrasa [Tue, 15 Aug 2017 20:09:05 +0000 (16:09 -0400)]
catalog: associate packages to their full_name

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agocatalog: extract gravatar from html
Alexandre Terrasa [Thu, 8 Jun 2017 23:00:02 +0000 (19:00 -0400)]
catalog: extract gravatar from html

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agocatalog: split metadata from MPackage class
Alexandre Terrasa [Thu, 8 Jun 2017 22:59:32 +0000 (18:59 -0400)]
catalog: split metadata from MPackage class

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agocatalog: fix warnings
Alexandre Terrasa [Thu, 8 Jun 2017 01:30:02 +0000 (21:30 -0400)]
catalog: fix warnings

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

6 years agoMerge: nitunit: use annotations
Jean Privat [Mon, 25 Sep 2017 20:23:07 +0000 (16:23 -0400)]
Merge: nitunit: use annotations

This PR replace the name heuristics used by nitunit by nice and tidy annotations.

Before:

~~~nit
module test_my_test is test_suite

import test_suite

class TestMyTest
    super TestSuite

    redef fun before do # something

    fun test_my_test do
        assert true
    end
end
~~~

After:

~~~nit
module my_test is test

class MyTest
    test

    fun setup is before do # something

    fun my_test is test do
        assert true
    end
end
~~~

Motivations:
* cleaner API / naming policy
* [BDD](https://en.wikipedia.org/wiki/Behavior-driven_development) friendly
* more flexibility as one can define a `after` method in the lib that will only be executed on children module tagged with `test`
* more extensible as one can improve nitunit to support `test(timeout = 150)` or `test(res= "res/test_file.res")`

Used annotations:
* `test` on modules, classes and properties to indicate that nitunit must run this module/class/method
* `before`, `after` on properties from all classes but `Sys` for the before/after each case hooks
* `before_all`, `after_all` on properties from `Sys` for the before/after all cases hooks

This also removes the need of the `lib/test_suite` module.

I also migrated the existing test suites to the new annotations system. Let's see what Jenkins has to say about it.

Should fix #2165

Pull-Request: #2474
Reviewed-by: Jean Privat <jean@pryen.org>

6 years agoMerge: gamnit: fluid API, named 3D models, faster nitpick et other fixes
Jean Privat [Mon, 25 Sep 2017 20:23:05 +0000 (16:23 -0400)]
Merge: gamnit: fluid API, named 3D models, faster nitpick et other fixes

General improvements to the gamnit framework and related services:
* Make the APIs of `CustomTexture` and `VirtualGamepad` a bit more fluid.
* More precise computation of `TextSprite::height` and show the result in `font_showcase`.
* Optimize shadow mapping by caching the light MVP matrix.
* Speedup nitpick by silencing some warnings in `glesv2` and fix warnings created by the serialization framework.
* Fix bug on Kabylake GPU reported by @BlackMinou.
* Fix a few other bugs and possible crashes.

Pull-Request: #2551

6 years agogamnit: fix "mismatching precision qualifiers" error on recent Intel GPU
Alexis Laferrière [Mon, 25 Sep 2017 12:38:37 +0000 (08:38 -0400)]
gamnit: fix "mismatching precision qualifiers" error on recent Intel GPU

Reported-by: Romain Chanoir <romain.chanoir@viacesi.fr>
Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agogamnit: disable our premultiplication on Android
Alexis Laferrière [Thu, 21 Sep 2017 01:51:54 +0000 (21:51 -0400)]
gamnit: disable our premultiplication on Android

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agogamnit: compute a more precise `TextSprites::height`
Alexis Laferrière [Fri, 15 Sep 2017 12:17:09 +0000 (08:17 -0400)]
gamnit: compute a more precise `TextSprites::height`

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agogamnit: fix code duplication in BMFont
Alexis Laferrière [Wed, 20 Sep 2017 16:45:33 +0000 (12:45 -0400)]
gamnit: fix code duplication in BMFont

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agogamnit: add size info to font_showcase
Alexis Laferrière [Wed, 20 Sep 2017 16:38:56 +0000 (12:38 -0400)]
gamnit: add size info to font_showcase

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agogamnit: cache the light mvp_matrix
Alexis Laferrière [Mon, 18 Sep 2017 19:21:06 +0000 (15:21 -0400)]
gamnit: cache the light mvp_matrix

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agoserialization: generate one less warning
Alexis Laferrière [Fri, 15 Sep 2017 15:53:45 +0000 (11:53 -0400)]
serialization: generate one less warning

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agoglesv2: don't report missing-doc warnings, for a faster nitpick
Alexis Laferrière [Fri, 15 Sep 2017 15:53:18 +0000 (11:53 -0400)]
glesv2: don't report missing-doc warnings, for a faster nitpick

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agogamnit: fix crash on character missing from font
Alexis Laferrière [Thu, 14 Sep 2017 17:48:19 +0000 (13:48 -0400)]
gamnit: fix crash on character missing from font

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agogamnit: more precise error when a texture is too large
Alexis Laferrière [Sat, 12 Aug 2017 16:10:36 +0000 (12:10 -0400)]
gamnit: more precise error when a texture is too large

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agogamnit: `CustomTexture::fill` returns self for easier attribute creation
Alexis Laferrière [Sat, 12 Aug 2017 16:10:27 +0000 (12:10 -0400)]
gamnit: `CustomTexture::fill` returns self for easier attribute creation

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agogamnit: keep the named sub-object composing an obj object
Alexis Laferrière [Tue, 1 Aug 2017 03:22:57 +0000 (23:22 -0400)]
gamnit: keep the named sub-object composing an obj object

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agogamnit: virtual gamepad services return the created controls
Alexis Laferrière [Tue, 1 Aug 2017 03:20:17 +0000 (23:20 -0400)]
gamnit: virtual gamepad services return the created controls

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agoMerge: Intro MessagePack serialization engines
Jean Privat [Fri, 22 Sep 2017 18:30:20 +0000 (14:30 -0400)]
Merge: Intro MessagePack serialization engines

MessagePack is a portable data serialization format. It differs from JSON by its binary format, compressing common types, support for custom types and accepting any object as map key. Here, the primitive Nit types use the shortest available MessagePack format (e.g. an `Int` between -32 and 127 takes a single byte). The custom types are used to declare some metadata and special types (objects, references, `Char`, etc.). The engines can, optionally, benefit from the map keys as any object to compress repeated metadata (class and attribute names).

These engines should replace the current `Binary::serialization` services, which are almost impossible to debug, less compressed than MessagePack and not standard.

The serialization engine supports writing and reading plain (no metadata) MessagePack data, similarly to the JSON engines.

Most clients should use the high-level services:
* Customizable engines to handle errors: `MsgPackSerializer` and `MsgPackDeserializer`.
* Quick services on streams: `Writer::serialize_msgpack` and `Reader::deserialize_msgpack`.
* Quick services on `Bytes` (mostly for testing): `Serializable::serialize_msgpack` and `Bytes::deserialize_msgpack`.

Or, to write engines one can use the low-level services:
* Low-level writing methods: `Writer::write_msgpack_uint64`, `Writer::write_msgpack_bin8`, etc.
* Low-level reading method: `Reader::read_msgpack`.

---

Using it in Jwrapper, the MessagePack format creates smaller files than JSON (at ~50% the size), when using the default options and serializing the metadata of the Java standard library:

* JSON: 14.9 MB
* MessagePack (default): 7.0 MB
* Old binary: 9.8 MB

The file gets shorter in plain MessagePack mode or when caching the metadata strings:
* MessagePack `plain_msgpack=true`: 6.3 MB
* MessagePack `cache_metadata_strings=true`: 3.0 MB

Caching metadata creates much smaller files, however for the size only gzip has a bigger effect.
Further investigations is required to see the impact it has on the speed.

* gzipped MessagePack (default): 0.7 MB
* gzipped MessagePack `cache_metadata_strings=true`: 0.6 MB

---

This PR depends on #2539 as it works on binary data, you can ignore the first 2 commits.

@R4PaSs you may want to look at the commits modifying `Int::to_bytes` and `Bytes::to_i`.

Pull-Request: #2550
Reviewed-by: Jean Privat <jean@pryen.org>

6 years agomsgpack: fixme interpreter bug in constructors with return (#2546)
Alexis Laferrière [Tue, 12 Sep 2017 16:21:27 +0000 (12:21 -0400)]
msgpack: fixme interpreter bug in constructors with return (#2546)

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agojwrapper: don't serialize cached attributes
Alexis Laferrière [Mon, 4 Sep 2017 01:59:15 +0000 (21:59 -0400)]
jwrapper: don't serialize cached attributes

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agojwrapper: use msgpack
Alexis Laferrière [Sun, 3 Sep 2017 23:37:15 +0000 (19:37 -0400)]
jwrapper: use msgpack

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agogamnit: use the msgpack engines instead of binary
Alexis Laferrière [Sun, 3 Sep 2017 23:03:18 +0000 (19:03 -0400)]
gamnit: use the msgpack engines instead of binary

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agomsgpack: test the msgpack serialization engines
Alexis Laferrière [Tue, 25 Jul 2017 20:53:46 +0000 (16:53 -0400)]
msgpack: test the msgpack serialization engines

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agomsgpack: intro msgpack_to_json tool
Alexis Laferrière [Wed, 26 Jul 2017 14:28:39 +0000 (10:28 -0400)]
msgpack: intro msgpack_to_json tool

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agomsgpack: intro entrypoint and package doc
Alexis Laferrière [Wed, 26 Jul 2017 02:36:32 +0000 (22:36 -0400)]
msgpack: intro entrypoint and package doc

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agomsgpack: intro deserialization services
Alexis Laferrière [Wed, 26 Jul 2017 02:36:08 +0000 (22:36 -0400)]
msgpack: intro deserialization services

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agomsgpack: intro serialization services
Alexis Laferrière [Tue, 25 Jul 2017 20:48:53 +0000 (16:48 -0400)]
msgpack: intro serialization services

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agomsgpack: intro read services
Alexis Laferrière [Tue, 25 Jul 2017 20:50:30 +0000 (16:50 -0400)]
msgpack: intro read services

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agomsgpack: intro write services
Alexis Laferrière [Tue, 25 Jul 2017 01:48:30 +0000 (21:48 -0400)]
msgpack: intro write services

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agocore: `Bytes::to_i` can parse signed ints
Alexis Laferrière [Sat, 2 Sep 2017 22:56:11 +0000 (18:56 -0400)]
core: `Bytes::to_i` can parse signed ints

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agocore: support signed ints and custom capacity in `Int::to_bytes`
Alexis Laferrière [Tue, 8 Aug 2017 16:23:18 +0000 (12:23 -0400)]
core: support signed ints and custom capacity in `Int::to_bytes`

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agoMerge: serialization: redef inspect for an output useful to humans
Jean Privat [Mon, 18 Sep 2017 19:00:47 +0000 (15:00 -0400)]
Merge: serialization: redef inspect for an output useful to humans

Intro a new serialization engine to pretty print the attributes of the receiver on calls to `inspect`. The format is designed to be helpful, reproducible and compact.

Note that, asides from direct calls to `inspect`, this will also affect the default behavior of `Serializable::to_s`. And this will not affect all Nit programs, but it will affect all those importing the serialization services, so most larger projects using either `json`, `nitcorn`, `gamnit`, `more_collections`, etc.

Simple immutable data are inspected as they would be written in Nit code:
~~~
assert 123.inspect == "123"
assert 1.5.inspect == "1.5"
assert 0xa1u8.inspect == "0xa1u8"
assert 'c'.inspect == "'c'"
assert "asdf\n".inspect == "\"asdf\\n\""
~~~

Inspections of mutable object show their dynamic type and an id unique to each call to `inspect`. A change from using their `object_id`.

Items of collections are flattened:

~~~
assert [1, 2, 3].inspect == "<Array[Int]#0 [1, 2, 3]>"

var set = new HashSet[Object].from([1, 1.5, "two": Object])
assert set.inspect == """<HashSet[Object]#0 [1, 1.5, "two"]>"""

var map = new Map[Int, String]
map[1] = "one"
map[2] = "two"
assert map.inspect == """<HashMap[Int, String]#0 {1:"one", 2:"two"}>"""
~~~

Inspecting other `Serializable` classes shows the first level attributes only:

~~~
class MyClass
    serialize

    var i: Int
    var o: nullable Object
end

var class_with_null = new MyClass(123)
assert class_with_null.to_s == class_with_null.inspect
assert class_with_null.to_s == "<MyClass#0 i:123, o:null>"

var class_with_other = new MyClass(456, class_with_null)
assert class_with_other.to_s == "<MyClass#0 i:456, o:<MyClass#1>>"

var class_with_cycle = new MyClass(789)
class_with_cycle.o = class_with_cycle
assert class_with_cycle.to_s == "<MyClass#0 i:789, o:<MyClass#0>>"
~~~

Inspections producing over 80 characters are cut short:

~~~
var long_class = new MyClass(123456789, "Some " + "very "*8 + "long string")
assert long_class.to_s == "<MyClass#0 i:123456789, o:\"Some very very very very very very very very long s…>"
~~~

Pull-Request: #2548
Reviewed-by: Jean Privat <jean@pryen.org>

6 years agoMerge: core: intro BytesWriter and BytesReader
Jean Privat [Mon, 18 Sep 2017 15:19:50 +0000 (11:19 -0400)]
Merge: core: intro BytesWriter and BytesReader

Intro the classes `BytesReader` and `BytesWriter` to support byte read/writer operations directly on `Bytes` in memory.

The new classes are now super classes to `StringReader` (converting the `String` source to `Bytes` in the constructor) and `StringWriter`(cleaning the UTF-8 string in `to_s` only). The only differences between the string and bytes streams are the behavior of `StringWriter::to_s` and the `String` parameter expected by the constructor of `StringReader`.

`BytesWriter` supports writing any bytes, including composing UTF-8 characters byte by byte, a behavior also useful for `StringWriter`:
~~~
var writer = new BytesWriter

# Write just the character first half
writer.write_byte 0xC2u8
assert writer.to_s == "\\xC2"
assert writer.bytes.to_s == "�"

# Complete the character
writer.write_byte 0xA2u8
assert writer.to_s == "\\xC2\\xA2"
assert writer.bytes.to_s == "¢"
~~~

`BytesReader` also supports reading any bytes, including the bytes composing an UTF-8 character for `StringReader`:

~~~
var reader = new BytesReader(b"a…b")
assert reader.read_char == 'a'
assert reader.read_byte == 0xE2u8 # 1st byte of '…'
assert reader.read_byte == 0x80u8 # 2nd byte of '…'
assert reader.read_char == '�' # Reads the last byte as an invalid char
assert reader.read_all_bytes == b"b"
~~~

Pull-Request: #2539
Reviewed-by: Jean Privat <jean@pryen.org>
Reviewed-by: Lucas Bajolet <r4pass@hotmail.com>

6 years agoMerge: app.nit: easier root window selection and other misc improvements
Jean Privat [Mon, 18 Sep 2017 15:19:48 +0000 (11:19 -0400)]
Merge: app.nit: easier root window selection and other misc improvements

Intro the hook `root_window` for clients to set the desired root (or home) window. It is much shorter than the previous redef of `on_create`. Plus, in very simple apps, the client can simple redef `Window` instead of subclassing it.

Refactor `data_store` structure, replacing the interface and subclasses by refinements of a single class. It follows more closely the strategy used by the UI API while not changing anything to the `data_store` API. The data store now drops potentially partially deserialized objects to avoid hard to report crash at runtime, this could be improved upon in the future as the current implementation is not ideal.

Otherwise, this PR brings general improvements to the framework influenced by the creation of [paninit.com](http://paninit.com/): revamp the documentation, add unit tests, fix the scientific calculator icon and add an option to report errors in `hightlightcode`.

Pull-Request: #2547
Reviewed-by: Jean Privat <jean@pryen.org>

6 years agoserialization: test the inspect serialization engine
Alexis Laferrière [Fri, 8 Sep 2017 00:53:57 +0000 (20:53 -0400)]
serialization: test the inspect serialization engine

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agoserialization: redef of `inspect` using a new serializer
Alexis Laferrière [Fri, 4 Aug 2017 02:34:02 +0000 (22:34 -0400)]
serialization: redef of `inspect` using a new serializer

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agocore: Bytes have a minimum capacity of 16 bytes
Alexis Laferrière [Fri, 8 Sep 2017 14:43:32 +0000 (10:43 -0400)]
core: Bytes have a minimum capacity of 16 bytes

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agocore: optimize Bytes::append_text using redefs in Text subclasses
Alexis Laferrière [Fri, 8 Sep 2017 14:06:31 +0000 (10:06 -0400)]
core: optimize Bytes::append_text using redefs in Text subclasses

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agocore: protect access to _items in empty strings
Alexis Laferrière [Thu, 7 Sep 2017 15:48:34 +0000 (11:48 -0400)]
core: protect access to _items in empty strings

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agoserialization: move serialization_core
Alexis Laferrière [Fri, 8 Sep 2017 00:45:41 +0000 (20:45 -0400)]
serialization: move serialization_core

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agocalculator: don't use fonts in the icon source
Alexis Laferrière [Thu, 7 Sep 2017 19:04:29 +0000 (15:04 -0400)]
calculator: don't use fonts in the icon source

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agoapp: add code example to data_store, http_request and ui
Alexis Laferrière [Thu, 7 Sep 2017 19:11:35 +0000 (15:11 -0400)]
app: add code example to data_store, http_request and ui

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agoapp: report errors in DataStore and fix a warning
Alexis Laferrière [Wed, 6 Sep 2017 19:46:59 +0000 (15:46 -0400)]
app: report errors in DataStore and fix a warning

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>

6 years agoapp: make DataStore a class and refine on each platform
Alexis Laferrière [Wed, 6 Sep 2017 19:46:22 +0000 (15:46 -0400)]
app: make DataStore a class and refine on each platform

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>