From 1b40c0f89cc7ccd7c7700efd72a64747c8a1d174 Mon Sep 17 00:00:00 2001 From: Jean Privat Date: Thu, 27 Nov 2014 15:30:01 -0500 Subject: [PATCH] typing: warn `useless-type` for useless type in a local variable Signed-off-by: Jean Privat --- src/semantize/typing.nit | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/semantize/typing.nit b/src/semantize/typing.nit index 3140de5..cdb8ae8 100644 --- a/src/semantize/typing.nit +++ b/src/semantize/typing.nit @@ -668,7 +668,11 @@ redef class AVardeclExpr var nexpr = self.n_expr if nexpr != null then if mtype != null then - v.visit_expr_subtype(nexpr, mtype) + var etype = v.visit_expr_subtype(nexpr, mtype) + if etype == mtype then + assert ntype != null + v.modelbuilder.advice(ntype, "useless-type", "Warning: useless type definition for variable `{variable.name}`") + end else mtype = v.visit_expr(nexpr) if mtype == null then return # Skip error -- 1.7.9.5