contrib/jwrapper: `JavaModel::classes` sort keys by string
[nit.git] / contrib / jwrapper / src / code_generator.nit
index 8141ee0..2d6012c 100644 (file)
@@ -26,7 +26,7 @@ class CodeGenerator
        var file_name: String
 
        # Model of Java class being wrapped
-       var java_class: JavaClass
+       var model: JavaModel
 
        # Comment out methods with unknown (unwrapped) types
        var comment_unknown_types: Bool
@@ -48,45 +48,47 @@ class CodeGenerator
        # Generate the Nit module into `file_out`
        fun generate
        do
-               var jclass = self.java_class
+               # License
+               file_out.write license
 
-               var class_content = new Array[String]
-               class_content.add(gen_class_header(jclass.class_type))
+               # Module declaration
+               var module_name = module_name
+               if module_name != null then file_out.write "module {module_name}\n"
+               file_out.write "\n"
 
-               for id, methods_info in jclass.methods do
-                       for method_info in methods_info do
-                               var nid = id
-                               if methods_info.length > 1 then nid += "{methods_info.index_of(method_info)}"
-                               class_content.add gen_method(id, nid, method_info.return_type, method_info.params)
-                       end
+               # All importations
+               var imports = new HashSet[String]
+               imports.add "import java\n"
+               for key, jclass in model.classes do
+                       for import_ in jclass.imports do imports.add "import android::{import_}\n"
                end
-               class_content.add("\nend\n")
+               file_out.write imports.join("\n")
+               file_out.write "\n"
 
-               var wrappers = new Array[String]
-               if stub_for_unknown_types then
-                       for jtype in jclass.unknown_types do
-                               if jtype == jclass.class_type then continue
-                               wrappers.add("\n")
-                               wrappers.add(gen_unknown_class_header(jtype))
-                       end
-               end
+               for key, jclass in model.classes do
 
-               var imports = new Array[String]
-               imports.add("import mnit_android\n")
-               for import_ in jclass.imports do
-                       imports.add("import android::{import_}\n")
-               end
+                       file_out.write gen_class_header(jclass.class_type)
 
-               file_out.write license
+                       for id, signatures in jclass.methods do
+                               var c = 0
+                               for signature in signatures do
+                                       var nid = id
+                                       if c > 0 then nid += c.to_s
+                                       c += 1
 
-               var module_name = module_name
-               if module_name != null then file_out.write "module {module_name}\n"
+                                       file_out.write gen_method(jclass, id, nid, signature.return_type, signature.params)
+                                       file_out.write "\n"
+                               end
+                       end
+                       file_out.write "end\n\n"
+               end
 
-               file_out.write("\n")
-               file_out.write(imports.join)
-               file_out.write("\n")
-               file_out.write(class_content.join)
-               file_out.write(wrappers.join)
+               if stub_for_unknown_types then
+                       for jtype in model.unknown_types do
+                               file_out.write gen_unknown_class_header(jtype)
+                               file_out.write "\n"
+                       end
+               end
        end
 
        # License for the header of the generated Nit module
@@ -111,20 +113,17 @@ class CodeGenerator
        fun gen_class_header(jtype: JavaType): String
        do
                var temp = new Array[String]
-               temp.add("extern class Native{jtype.id} in \"Java\" `\{ {jtype} `\}\n")
-               temp.add("\tsuper JavaObject\n\n")
+               var nit_type = jtype.to_nit_type
+               temp.add "# Java class: {jtype.to_package_name}\n"
+               temp.add "extern class {nit_type} in \"Java\" `\{ {jtype.to_package_name} `\}\n"
+               temp.add "\tsuper JavaObject\n\n"
 
                return temp.join
        end
 
        fun gen_unknown_class_header(jtype: JavaType): String
        do
-               var nit_type: NitType
-               if jtype.extern_name.has_generic_params then
-                       nit_type = jtype.extern_name.generic_params.first
-               else
-                       nit_type = jtype.extern_name
-               end
+               var nit_type = jtype.extern_name
 
                var temp = new Array[String]
                temp.add("extern class {nit_type} in \"Java\" `\{ {jtype.to_package_name} `\}\n")
@@ -133,7 +132,7 @@ class CodeGenerator
                return temp.join
        end
 
-       fun gen_method(jmethod_id: String, nmethod_id: String, jreturn_type: JavaType, jparam_list: Array[JavaType]): String
+       fun gen_method(java_class: JavaClass, jmethod_id, nmethod_id: String, jreturn_type: JavaType, jparam_list: Array[JavaType]): String
        do
                var java_params = ""
                var nit_params  = ""
@@ -151,7 +150,7 @@ class CodeGenerator
                                if jparam.is_wrapped then
                                        java_class.imports.add nit_type.mod.as(not null)
                                else
-                                       java_class.unknown_types.add jparam
+                                       model.unknown_types.add jparam
                                        if comment_unknown_types then
                                                comment = "#"
                                        else
@@ -165,7 +164,6 @@ class CodeGenerator
                        if not jparam.is_collection then cast = jparam.param_cast
 
                        nit_types.add(nit_type)
-                       nit_type.arg_id = "{nit_id}{nit_id_no}"
 
                        if i == jparam_list.length - 1 then
                                java_params += "{cast}{nit_id}{nit_id_no}"
@@ -178,6 +176,9 @@ class CodeGenerator
                        nit_id_no += 1
                end
 
+               # Method documentation
+               var doc = "\t# Java implementation: {java_class}.{jmethod_id}\n"
+
                # Method identifier
                var method_id = nmethod_id.to_nit_method_name
                var nit_signature = new Array[String]
@@ -197,7 +198,7 @@ class CodeGenerator
                                if jreturn_type.is_wrapped then
                                        java_class.imports.add return_type.mod.as(not null)
                                else
-                                       java_class.unknown_types.add jreturn_type
+                                       model.unknown_types.add jreturn_type
                                        if comment_unknown_types then
                                                comment = "#"
                                        else
@@ -211,9 +212,9 @@ class CodeGenerator
 
                var temp = new Array[String]
 
+               temp.add doc
                temp.add(comment + nit_signature.join)
 
-               # FIXME : This huge `if` block is only necessary to copy primitive arrays as long as there's no better way to do it
                if comment == "#" then
                        temp.add(" in \"Java\" `\{\n{comment}\t\tself.{jmethod_id}({java_params});\n{comment}\t`\}\n")
                # Methods with return type
@@ -231,7 +232,19 @@ class CodeGenerator
        end
 end
 
+redef class Sys
+       # List of Nit keywords
+       #
+       # These may also be keywords in Java, but there they would be used capitalized.
+       private var nit_keywords: Array[String] = ["abort", "abstract", "and", "assert",
+               "break", "class", "continue", "do", "else", "end", "enum", "extern", "false", "implies",
+               "import", "init", "interface", "intrude", "if", "in", "is", "isa", "isset", "for", "label",
+               "loop", "module", "new", "not", "null", "nullable", "or", "package", "private",
+               "protected", "public", "return", "self", "super", "then", "true", "type", "var", "while"]
+end
+
 redef class String
+
        # Convert the Java method name `self` to the Nit style
        #
        # * Converts to snake case
@@ -243,9 +256,22 @@ redef class String
                if name.has_prefix("get_") then
                        name = name.substring_from(4)
                else if name.has_prefix("set_") then
-                       name = name.substring_from(4) + "="
+                       name = name.substring_from(4)
+                       if nit_keywords.has(name) then name += "_"
+                       name += "="
                end
 
+               # Strip the '_' prefix
+               while name.has_prefix("_") do name = name.substring(1, name.length-1)
+
+               # Escape Nit keywords
+               if nit_keywords.has(name) then name += "_"
+
+               # If the name starts by something other than a letter, prefix with `java_`
+               if not name.chars.first.is_letter then name = "java_" + name
+
+               name = name.replace("$", "_")
+
                return name
        end
 end