metamodel: fast-fail in getters
[nit.git] / src / syntax / typing.nit
index e784269..d8ca9de 100644 (file)
@@ -18,6 +18,7 @@
 package typing
 
 import syntax_base
+import escape
 
 redef class MMSrcModule
        # Walk trough the module and type statments and expressions
@@ -44,21 +45,15 @@ special AbsSyntaxVisitor
        # Current knowledge about variables names and types
        readable writable attr _variable_ctx: VariableContext
 
+       # Current knowledge about escapable blocks
+       readable writable attr _escapable_ctx: EscapableContext = new EscapableContext(self)
+
        # The current reciever
        readable writable attr _self_var: ParamVariable
 
        # Block of the current method
        readable writable attr _top_block: PExpr
 
-       # Current closure 'return' static type (if any)
-       readable writable attr _closure_stype: MMType
-
-       # Current closure method return type (for break) (if any)
-       readable writable attr _closure_break_stype: MMType = null
-
-       # Current closure break expressions (if any)
-       readable writable attr _break_list: Array[PExpr]
-
        # List of explicit invocation of constructors of super-classes
        readable writable attr _explicit_super_init_calls: Array[MMMethod]
 
@@ -198,7 +193,6 @@ special VariableContext
        end
 end
 
-
 ###############################################################################
 
 redef class PNode
@@ -298,9 +292,24 @@ redef class PParam
 end
 
 redef class AClosureDecl
-       redef meth after_typing(v)
+       # The corresponding escapable object
+       readable attr _escapable: EscapableBlock
+
+       redef meth accept_typing(v)
        do
+               # Register the closure for ClosureCallExpr
                v.variable_ctx.add(variable)
+
+               var old_var_ctx = v.variable_ctx
+               v.variable_ctx = v.variable_ctx.sub
+
+               _escapable = new EscapableClosure(self, variable.closure, null)
+               v.escapable_ctx.push(_escapable)
+
+               super
+
+               v.variable_ctx = old_var_ctx
+               v.escapable_ctx.pop
        end
 end
 
@@ -376,11 +385,19 @@ end
 redef class AContinueExpr
        redef meth after_typing(v)
        do
-               var t = v.closure_stype
+               var esc = compute_escapable_block(v.escapable_ctx)
+               if esc == null then return
+
+               if esc.is_break_block then
+                       v.error(self, "Error: 'continue' forbiden in break blocks.")
+                       return
+               end
+
+               var t = esc.continue_stype
                if n_expr == null and t != null then
-                       v.error(self, "Error: continue with a value required in this bloc.")
+                       v.error(self, "Error: continue with a value required in this block.")
                else if n_expr != null and t == null then
-                       v.error(self, "Error: continue without value required in this bloc.")
+                       v.error(self, "Error: continue without value required in this block.")
                else if n_expr != null and t != null then
                        v.check_conform_expr(n_expr, t)
                end
@@ -390,14 +407,17 @@ end
 redef class ABreakExpr
        redef meth after_typing(v)
        do
-               var t = v.closure_break_stype
-               if n_expr == null and t != null then
-                       v.error(self, "Error: break with a value required in this bloc.")
-               else if n_expr != null and t == null then
-                       v.error(self, "Error: break without value required in this bloc.")
-               else if n_expr != null and t != null then
+               var esc = compute_escapable_block(v.escapable_ctx)
+               if esc == null then return
+
+               var bl = esc.break_list
+               if n_expr == null and bl != null then
+                       v.error(self, "Error: break with a value required in this block.")
+               else if n_expr != null and bl == null then
+                       v.error(self, "Error: break without value required in this block.")
+               else if n_expr != null and bl != null then
                        # Typing check can only be done later
-                       v.break_list.add(n_expr)
+                       bl.add(n_expr)
                end
        end
 end
@@ -425,48 +445,78 @@ redef class AIfExpr
 end
 
 redef class AWhileExpr
-       redef meth after_typing(v)
+       # The corresponding escapable block
+       readable attr _escapable: EscapableBlock
+
+       redef meth accept_typing(v)
        do
+               _escapable = new EscapableBlock(self)
+               v.escapable_ctx.push(_escapable)
+
+               super
+
                v.check_conform_expr(n_expr, v.type_bool)
+               v.escapable_ctx.pop
        end
 end
 
 redef class AForExpr
-       redef meth after_typing(v)
-       do
-               # pop context created in AForVardeclExpr
-               var varctx = v.variable_ctx 
-               assert varctx isa SubVariableContext
-               v.variable_ctx = varctx.prev
-       end
-end
+       # The corresponding escapable block
+       readable attr _escapable: EscapableBlock
 
-redef class AForVardeclExpr
-       redef meth after_typing(v)
+       readable attr _meth_iterator: MMMethod
+       readable attr _meth_is_ok: MMMethod
+       readable attr _meth_item: MMMethod
+       readable attr _meth_next: MMMethod
+       redef meth accept_typing(v)
        do
+               _escapable = new EscapableBlock(self)
+               v.escapable_ctx.push(_escapable)
+
                v.variable_ctx = v.variable_ctx.sub
                var va = new AutoVariable(n_id.to_symbol, self)
                variable = va
                v.variable_ctx.add(va)
 
+               v.visit(n_expr)
+
                var expr_type = n_expr.stype
                if not v.check_conform_expr(n_expr, v.type_collection) then
                        return
                end
-               var prop = expr_type.local_class.select_method(once ("iterator".to_symbol))
-               if prop == null then
+               _meth_iterator = expr_type.local_class.select_method(once ("iterator".to_symbol))
+               if _meth_iterator == null then
                        v.error(self, "Error: Collection MUST have an iterate method")
                        return
                end
-               var iter_type = prop.signature_for(expr_type).return_type
-               var prop2 = iter_type.local_class.select_method(once ("item".to_symbol))
-               if prop2 == null then
+               var iter_type = _meth_iterator.signature_for(expr_type).return_type
+               _meth_is_ok = iter_type.local_class.select_method(once ("is_ok".to_symbol))
+               if _meth_is_ok == null then
+                       v.error(self, "Error: {iter_type} MUST have an is_ok method")
+                       return
+               end
+               _meth_item = iter_type.local_class.select_method(once ("item".to_symbol))
+               if _meth_item == null then
                        v.error(self, "Error: {iter_type} MUST have an item method")
                        return
                end
-               var t = prop2.signature_for(iter_type).return_type
+               _meth_next = iter_type.local_class.select_method(once ("next".to_symbol))
+               if _meth_next == null then
+                       v.error(self, "Error: {iter_type} MUST have a next method")
+                       return
+               end
+               var t = _meth_item.signature_for(iter_type).return_type
                if not n_expr.is_self then t = t.not_for_self
                va.stype = t
+
+               if n_block != null then v.visit(n_block)
+
+               # pop context
+               var varctx = v.variable_ctx 
+               assert varctx isa SubVariableContext
+               v.variable_ctx = varctx.prev
+
+               v.escapable_ctx.pop
        end
 end
 
@@ -503,11 +553,12 @@ redef class AReassignFormExpr
                        return
                end
                var name = n_assign_op.method_name
-               var prop = type_lvalue.local_class.select_method(name)
-               if prop == null then
+               var lc = type_lvalue.local_class
+               if not lc.has_global_property_by_name(name) then
                        v.error(self, "Error: Method '{name}' doesn't exists in {type_lvalue}.")
                        return
                end
+               var prop = lc.select_method(name)
                prop.global.check_visibility(v, self, v.module, false)
                var psig = prop.signature_for(type_lvalue)
                _assign_method = prop
@@ -651,16 +702,30 @@ redef class ACharExpr
 end
 
 redef class AStringFormExpr
+       readable attr _meth_with_native: MMMethod
        redef meth after_typing(v)
        do
                _stype = v.type_string
+               _meth_with_native = _stype.local_class.select_method(once "with_native".to_symbol)
+               if _meth_with_native == null then v.error(self, "{_stype} MUST have a with_native method.")
        end
 end
 
 redef class ASuperstringExpr
+       readable attr _meth_with_capacity: MMMethod
+       readable attr _meth_add: MMMethod
+       readable attr _meth_to_s: MMMethod
+       readable attr _atype: MMType
        redef meth after_typing(v)
        do
                _stype = v.type_string
+               _atype = v.type_array(_stype)
+               _meth_with_capacity = _atype.local_class.select_method(once "with_capacity".to_symbol)
+               if _meth_with_capacity == null then v.error(self, "{_atype} MUST have a with_capacity method.")
+               _meth_add = _atype.local_class.select_method(once "add".to_symbol)
+               if _meth_add == null then v.error(self, "{_atype} MUST have an add method.")
+               _meth_to_s = v.type_object.local_class.select_method(once "to_s".to_symbol)
+               if _meth_to_s == null then v.error(self, "Object MUST have a to_s method.")
        end
 end
 
@@ -672,7 +737,8 @@ redef class ANullExpr
 end
 
 redef class AArrayExpr
-       private meth stype=(t: MMType) do _stype = t
+       readable attr _meth_with_capacity: MMMethod
+       readable attr _meth_add: MMMethod
 
        redef meth after_typing(v)
        do
@@ -686,11 +752,22 @@ redef class AArrayExpr
                for n in n_exprs do
                        v.check_conform_expr(n, stype)
                end
-               _stype = v.type_array(stype)
+               do_typing(v, stype)
+       end
+
+       private meth do_typing(v: TypingVisitor, element_type: MMType)
+       do
+               _stype = v.type_array(element_type)
+
+               _meth_with_capacity = _stype.local_class.select_method(once "with_capacity".to_symbol)
+               if _meth_with_capacity == null then v.error(self, "{_stype} MUST have a with_capacity method.")
+               _meth_add = _stype.local_class.select_method(once "add".to_symbol)
+               if _meth_add == null then v.error(self, "{_stype} MUST have an add method.")
        end
 end
 
 redef class ARangeExpr
+       readable attr _meth_init: MMMethod
        redef meth after_typing(v)
        do
                var ntype = n_expr.stype
@@ -711,6 +788,22 @@ redef class ARangeExpr
        end
 end
 
+redef class ACrangeExpr
+       redef meth after_typing(v)
+       do
+               super
+               _meth_init = stype.local_class.select_method(once "init".to_symbol)
+       end
+end
+redef class AOrangeExpr
+       redef meth after_typing(v)
+       do
+               super
+               _meth_init = stype.local_class.select_method(once "without_last".to_symbol)
+       end
+end
+
+
 redef class ASuperExpr
 special ASuperInitCall
        # readable attr _prop: MMSrcMethod
@@ -784,11 +877,13 @@ redef class AAttrFormExpr
                if not v.check_expr(n_expr) then return
                var type_recv = n_expr.stype
                var name = n_id.to_symbol
-               var prop = type_recv.local_class.select_attribute(name)
-               if prop == null then
+               var lc = type_recv.local_class
+               if not lc.has_global_property_by_name(name) then
                        v.error(self, "Error: Attribute {name} doesn't exists in {type_recv}.")
                        return
-               else if v.module.visibility_for(prop.global.local_class.module) < 3 then
+               end
+               var prop = lc.select_attribute(name)
+               if v.module.visibility_for(prop.global.local_class.module) < 3 then
                        v.error(self, "Error: Attribute {name} from {prop.global.local_class.module} is invisible in {v.module}")
                end
                _prop = prop
@@ -837,7 +932,7 @@ special PExpr
        readable attr _prop_signature: MMSignature
 
        # Compute the called global property
-       private meth do_typing(v: TypingVisitor, type_recv: MMType, is_implicit_self: Bool, recv_is_self: Bool, name: Symbol, raw_args: Array[PExpr])
+       private meth do_typing(v: TypingVisitor, type_recv: MMType, is_implicit_self: Bool, recv_is_self: Bool, name: Symbol, raw_args: Array[PExpr], closure_defs: Array[PClosureDef])
        do
                var prop = get_property(v, type_recv, is_implicit_self, name)
                if prop == null then return
@@ -845,15 +940,19 @@ special PExpr
                if sig == null then return
                var args = process_signature(v, sig, prop.name, raw_args)
                if args == null then return
+               var rtype = process_closures(v, sig, prop.name, closure_defs)
                _prop = prop
                _prop_signature = sig
                _arguments = args
+               _return_type = rtype
        end
 
        private meth get_property(v: TypingVisitor, type_recv: MMType, is_implicit_self: Bool, name: Symbol): MMMethod
        do
                if type_recv == null then return null
-               var prop = type_recv.local_class.select_method(name)
+               var lc = type_recv.local_class
+               var prop: MMMethod = null
+               if lc.has_global_property_by_name(name) then prop = lc.select_method(name)
                if prop == null and v.local_property.global.is_init then
                        var props = type_recv.local_class.super_methods_named(name)
                        if props.length > 1 then
@@ -877,6 +976,7 @@ special PExpr
                return prop
        end
 
+       # Get the signature for a local property and a receiver
        private meth get_signature(v: TypingVisitor, type_recv: MMType, prop: MMMethod, recv_is_self: Bool): MMSignature
        do
                prop.global.check_visibility(v, self, v.module, recv_is_self)
@@ -884,7 +984,7 @@ special PExpr
                if not recv_is_self then psig = psig.not_for_self
                return psig
        end
-       
+
        # Check the conformity of a set of arguments `raw_args' to a signature.
        private meth process_signature(v: TypingVisitor, psig: MMSignature, name: Symbol, raw_args: Array[PExpr]): Array[PExpr]
        do
@@ -910,7 +1010,7 @@ special PExpr
                                        arg_idx = arg_idx + 1
                                end
                                var aa = new AArrayExpr.init_aarrayexpr(star)
-                               aa.stype = v.type_array(par_type)
+                               aa.do_typing(v, par_type)
                                a = aa
                        else
                                a = raw_args[arg_idx]
@@ -922,11 +1022,62 @@ special PExpr
                return args
        end
 
+       # Check the conformity of a set of defined closures
+       private meth process_closures(v: TypingVisitor, psig: MMSignature, name: Symbol, cd: Array[PClosureDef]): MMType
+       do
+               var t = psig.return_type
+               var cs = psig.closures # Declared closures
+               var min_arity = 0
+               for c in cs do
+                       if not c.is_optional then min_arity += 1
+               end
+               if cd != null then
+                       if cs.length == 0 then
+                               v.error(self, "Error: {name} does not require blocks.")
+                       else if cd.length > cs.length or cd.length < min_arity then
+                               v.error(self, "Error: {name} requires {cs.length} blocks, {cd.length} found.")
+                       else
+                               # Initialize the break list if a value is required for breaks (ie. if the method is a function)
+                               var break_list: Array[ABreakExpr] = null
+                               if t != null then break_list = new Array[ABreakExpr]
+
+                               # Process each closure definition
+                               for i in [0..cd.length[ do
+                                       var csi = cs[i]
+                                       var cdi = cd[i]
+                                       var esc = new EscapableClosure(cdi, csi, break_list)
+                                       v.escapable_ctx.push(esc)
+                                       cdi.accept_typing2(v, esc)
+                                       v.escapable_ctx.pop
+                               end
+
+                               # Check break type conformity
+                               if break_list != null then
+                                       for n in break_list do
+                                               var ntype = n.stype
+                                               if t == null or (t != null and t < ntype) then
+                                                       t = ntype
+                                               end
+                                       end
+                                       for n in break_list do
+                                               v.check_conform_expr(n, t)
+                                       end
+                               end
+                       end
+               else if min_arity != 0 then
+                       v.error(self, "Error: {name} requires {cs.length} blocks.")
+               end
+               return t
+       end
+
        # The invoked method (once computed)
        readable attr _prop: MMMethod
 
        # The real arguments used (after star transformation) (once computed)
        readable attr _arguments: Array[PExpr]
+
+       # The return type (if any) (once computed)
+       readable attr _return_type: MMType
 end
 
 # A possible call of constructor in a super class
@@ -985,7 +1136,7 @@ special AAbsSendExpr
                        name = n_id.to_symbol
                end
 
-               do_typing(v, t, false, false, name, n_args.to_a)
+               do_typing(v, t, false, false, name, n_args.to_a, null)
                if prop == null then return
 
                if not prop.global.is_init then
@@ -1015,44 +1166,9 @@ special ASuperInitCall
        private meth do_all_typing(v: TypingVisitor)
        do
                if not v.check_expr(n_expr) then return
-               do_typing(v, n_expr.stype, n_expr.is_implicit_self, n_expr.is_self, name, raw_arguments)
+               do_typing(v, n_expr.stype, n_expr.is_implicit_self, n_expr.is_self, name, raw_arguments, closure_defs)
                if prop == null then return
 
-               var t = prop.signature_for(n_expr.stype).return_type
-               if t != null and not n_expr.is_self then t = t.not_for_self
-
-               var cd = closure_defs
-               var cs = _prop_signature.closures # Closure signatures
-               if cd != null then
-                       if cs.length == 0 then
-                               v.error(self, "Error: property {prop} does not require blocs.")
-                       else if cs.length != cd.length then
-                               v.error(self, "Error: property {prop} requires {cs.length} blocs, {cd.length} found.")
-                       else
-                               var old_bbst = v.closure_break_stype
-                               var old_bl = v.break_list
-                               v.closure_break_stype = t
-                               v.break_list = new Array[ABreakExpr]
-                               for i in [0..cs.length[ do
-                                       cd[i].accept_typing2(v, cs[i])
-                               end
-                               for n in v.break_list do
-                                       var ntype = n.stype
-                                       if t == null or (t != null and t < ntype) then
-                                               t = ntype
-                                       end
-                               end
-                               for n in v.break_list do
-                                       v.check_conform_expr(n, t)
-                               end
-
-                               v.closure_break_stype = old_bbst
-                               v.break_list = old_bl
-                       end
-               else if cs.length != 0 then
-                       v.error(self, "Error: property {prop} requires {cs.length} blocs.")
-               end
-
                if prop.global.is_init then
                        if not v.local_property.global.is_init then
                                v.error(self, "Error: try to invoke constructor {prop} in a method.")
@@ -1062,7 +1178,8 @@ special ASuperInitCall
                                register_super_init_call(v, prop)
                        end
                end
-               _stype = t
+
+               _stype = return_type
        end
 end
 
@@ -1074,7 +1191,7 @@ special AReassignFormExpr
        do
                if not v.check_expr(n_expr) then return
                var raw_args = raw_arguments
-               do_typing(v, n_expr.stype, n_expr.is_implicit_self, n_expr.is_self, name, raw_args)
+               do_typing(v, n_expr.stype, n_expr.is_implicit_self, n_expr.is_self, name, raw_args, null)
                if prop == null then return
                if prop.global.is_init then
                        if not v.local_property.global.is_init then
@@ -1092,7 +1209,7 @@ special AReassignFormExpr
                var old_args = arguments
                raw_args.add(n_value)
 
-               do_typing(v, n_expr.stype, n_expr.is_implicit_self, n_expr.is_self, "{name}=".to_symbol, raw_args)
+               do_typing(v, n_expr.stype, n_expr.is_implicit_self, n_expr.is_self, "{name}=".to_symbol, raw_args, null)
                if prop == null then return
                if prop.global.is_init then
                        if not v.local_property.global.is_init then
@@ -1176,9 +1293,10 @@ redef class ACallFormExpr
                                end
                        end
                end
+
                super
        end
-       
+
        redef meth closure_defs
        do
                if n_closure_defs == null or n_closure_defs.is_empty then
@@ -1256,8 +1374,11 @@ redef class AClosureCallExpr
        redef meth after_typing(v)
        do
                var va = variable
-               var sig = va.closure.signature 
+               var sig = va.closure.signature
                var args = process_signature(v, sig, n_id.to_symbol, n_args.to_a)
+               if closure_defs != null then
+                       process_closures(v, sig, n_id.to_symbol, closure_defs)
+               end
                if args == null then return
                _prop = null
                _prop_signature = sig
@@ -1267,6 +1388,9 @@ redef class AClosureCallExpr
 end
 
 redef class PClosureDef
+       # The corresponding escapable object
+       readable attr _escapable: EscapableBlock
+
        attr _accept_typing2: Bool
        redef meth accept_typing(v)
        do
@@ -1274,22 +1398,21 @@ redef class PClosureDef
                if _accept_typing2 then super
        end
 
-       private meth accept_typing2(v: TypingVisitor, clos: MMClosure) is abstract
+       private meth accept_typing2(v: TypingVisitor, esc: EscapableClosure) is abstract
 end
 
 redef class AClosureDef
-       redef meth accept_typing2(v, clos)
-       do      
-               var sig = clos.signature
+       redef meth accept_typing2(v, esc)
+       do
+               _escapable = esc
+
+               var sig = esc.closure.signature
                if sig.arity != n_id.length then
                        v.error(self, "Error: {sig.arity} automatic variable names expected, {n_id.length} found.")
                        return
                end
 
-               closure = clos
-
-               var old_stype = v.closure_stype
-               v.closure_stype = sig.return_type
+               closure = esc.closure
 
                v.variable_ctx = v.variable_ctx.sub
                variables = new Array[AutoVariable]
@@ -1302,8 +1425,6 @@ redef class AClosureDef
 
                _accept_typing2 = true
                accept_typing(v)
-
-               v.closure_stype = old_stype
        end
 end