nitlanguage
/
nit.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
typing: new PostTypingVisitor that is run after the visit
[nit.git]
/
src
/
semantize
/
typing.nit
diff --git
a/src/semantize/typing.nit
b/src/semantize/typing.nit
index
ada6160
..
ffd68e7
100644
(file)
--- a/
src/semantize/typing.nit
+++ b/
src/semantize/typing.nit
@@
-329,6
+329,8
@@
private class TypeVisitor
if recvtype isa MNullType and not mproperty.is_null_safe then
self.error(node, "Error: method `{name}` called on `null`.")
return null
if recvtype isa MNullType and not mproperty.is_null_safe then
self.error(node, "Error: method `{name}` called on `null`.")
return null
+ else if unsafe_type isa MNullableType and not mproperty.is_null_safe then
+ modelbuilder.advice(node, "call-on-nullable", "Warning: method call on a nullable receiver `{recvtype}`.")
end
if is_toplevel_context and recv_is_self and not mproperty.is_toplevel then
end
if is_toplevel_context and recv_is_self and not mproperty.is_toplevel then
@@
-646,7
+648,7
@@
end
redef class Variable
# The declared type of the variable
redef class Variable
# The declared type of the variable
- var declared_type: nullable MType
+ var declared_type: nullable MType is writable
# Was the variable type-adapted?
# This is used to speedup type retrieval while it remains `false`
# Was the variable type-adapted?
# This is used to speedup type retrieval while it remains `false`
@@
-746,6
+748,9
@@
redef class AMethPropdef
if not v.has_loop or not v.dirty then break
end
if not v.has_loop or not v.dirty then break
end
+ var post_visitor = new PostTypingVisitor(v)
+ post_visitor.enter_visit(self)
+
if not nblock.after_flow_context.is_unreachable and msignature.return_mtype != null then
# We reach the end of the function without having a return, it is bad
v.error(self, "Error: reached end of function; expected `return` with a value.")
if not nblock.after_flow_context.is_unreachable and msignature.return_mtype != null then
# We reach the end of the function without having a return, it is bad
v.error(self, "Error: reached end of function; expected `return` with a value.")
@@
-753,20
+758,33
@@
redef class AMethPropdef
end
end
end
end
+private class PostTypingVisitor
+ super Visitor
+ var type_visitor: TypeVisitor
+ redef fun visit(n) do
+ n.visit_all(self)
+ n.accept_post_typing(type_visitor)
+ end
+end
+
+redef class ANode
+ private fun accept_post_typing(v: TypeVisitor) do end
+end
+
redef class AAttrPropdef
redef fun do_typing(modelbuilder: ModelBuilder)
do
if not has_value then return
redef class AAttrPropdef
redef fun do_typing(modelbuilder: ModelBuilder)
do
if not has_value then return
- var mpropdef = self.mpropdef
- if mpropdef == null then return # skip error
+ var mpropdef = self.mreadpropdef
+ if mpropdef == null or mpropdef.msignature == null then return # skip error
var v = new TypeVisitor(modelbuilder, mpropdef.mclassdef.mmodule, mpropdef)
self.selfvariable = v.selfvariable
var nexpr = self.n_expr
if nexpr != null then
var v = new TypeVisitor(modelbuilder, mpropdef.mclassdef.mmodule, mpropdef)
self.selfvariable = v.selfvariable
var nexpr = self.n_expr
if nexpr != null then
- var mtype = self.mpropdef.static_mtype
+ var mtype = self.mtype
v.visit_expr_subtype(nexpr, mtype)
end
var nblock = self.n_block
v.visit_expr_subtype(nexpr, mtype)
end
var nblock = self.n_block
@@
-958,7
+976,7
@@
redef class AVarReassignExpr
v.set_variable(self, variable, rettype)
v.set_variable(self, variable, rettype)
- self.is_typed = true
+ self.is_typed = rettype != null
end
end
end
end
@@
-1004,9
+1022,11
@@
redef class AReturnExpr
else
v.visit_expr(nexpr)
v.error(nexpr, "Error: `return` with value in a procedure.")
else
v.visit_expr(nexpr)
v.error(nexpr, "Error: `return` with value in a procedure.")
+ return
end
else if ret_type != null then
v.error(self, "Error: `return` without value in a function.")
end
else if ret_type != null then
v.error(self, "Error: `return` without value in a function.")
+ return
end
self.is_typed = true
end
end
self.is_typed = true
end
@@
-1300,7
+1320,8
@@
redef class AOrElseExpr
end
if t1 isa MNullType then
end
if t1 isa MNullType then
- v.error(n_expr, "Type Error: `or else` on `null`.")
+ self.mtype = t2
+ return
else if v.check_can_be_null(n_expr, t1) then
t1 = t1.as_notnull
end
else if v.check_can_be_null(n_expr, t1) then
t1 = t1.as_notnull
end
@@
-1342,6
+1363,15
@@
redef class AIntExpr
end
end
end
end
+redef class AByteExpr
+ redef fun accept_typing(v)
+ do
+ var mclass = v.get_mclass(self, "Byte")
+ if mclass == null then return # Forward error
+ self.mtype = mclass.mclass_type
+ end
+end
+
redef class AFloatExpr
redef fun accept_typing(v)
do
redef class AFloatExpr
redef fun accept_typing(v)
do
@@
-1675,14
+1705,8
@@
redef class ABinopExpr
redef fun property_name do return operator
redef fun property_node do return n_op
end
redef fun property_name do return operator
redef fun property_node do return n_op
end
-redef class AEqExpr
- redef fun accept_typing(v)
- do
- super
- v.null_test(self)
- end
-end
-redef class ANeExpr
+
+redef class AEqFormExpr
redef fun accept_typing(v)
do
super
redef fun accept_typing(v)
do
super
@@
-2050,7
+2074,7
@@
redef class AAttrAssignExpr
var mtype = self.attr_type
v.visit_expr_subtype(self.n_value, mtype)
var mtype = self.attr_type
v.visit_expr_subtype(self.n_value, mtype)
- self.is_typed = true
+ self.is_typed = mtype != null
end
end
end
end
@@
-2061,9
+2085,9
@@
redef class AAttrReassignExpr
var mtype = self.attr_type
if mtype == null then return # Skip error
var mtype = self.attr_type
if mtype == null then return # Skip error
- self.resolve_reassignment(v, mtype, mtype)
+ var rettype = self.resolve_reassignment(v, mtype, mtype)
- self.is_typed = true
+ self.is_typed = rettype != null
end
end
end
end