end
end
- # A mixin class can be build the same way that one of its superclasses
- readable attr _is_mixin: Bool = false
-
# Introduce or inherit default constructors
private meth process_default_constructors(v: PropertyBuilderVisitor)
do
for gp in super_constructors do
var sc = gp.local_class
if supers.has(sc) then continue
- assert sc isa MMSrcLocalClass
- if not sc.is_mixin then
+ if not sc.global.is_mixin then
supers.add(sc)
end
end
make_visible_an_inherited_global_property(gp)
end
end
- _is_mixin = true
+ global.mixin_of = superclass.global
else
# v.error(nodes.first, "Error, constructor required in {self} since no anonimous init found in {sc}.")
# * Check property conformance
private class PropertyVerifierVisitor
special AbsSyntaxVisitor
+
+ # The signature currently build
+ readable writable attr _signature_builder: SignatureBuilder
+
+ redef meth visit(n) do n.accept_property_verifier(self)
+
+ init(tc, m)
+ do
+ super
+ _signature_builder = new SignatureBuilder
+ end
+end
+
+# Information about a signature currently build
+private class SignatureBuilder
# Current visited parameter types
- readable writable attr _params: Array[PParam]
+ readable writable attr _params: Array[PParam] = new Array[PParam]
# Visited parameters without type information added
- readable writable attr _untyped_params: Array[PParam]
+ readable writable attr _untyped_params: Array[PParam] = new Array[PParam]
# Position of the current star parameter
- readable writable attr _vararg_rank: Int
+ readable writable attr _vararg_rank: Int = -1
- # Current signature
- readable writable attr _signature: MMSignature
+ # Current closure declarations
+ readable writable attr _closure_decls: Array[AClosureDecl] = new Array[AClosureDecl]
- redef meth visit(n) do n.accept_property_verifier(self)
-
- init(tc, m) do super
+ # Current signature
+ readable writable attr _signature: MMSignature = null
end
###############################################################################
end
if prop.signature != null then
# ok
- else if not v.untyped_params.is_empty then
- v.error(v.untyped_params.first, "Error: Untyped parameter.")
+ else if not v.signature_builder.untyped_params.is_empty then
+ v.error(v.signature_builder.untyped_params.first, "Error: Untyped parameter.")
else
prop.signature = new MMSignature(new Array[MMType], null, v.local_class.get_type)
+ if v.signature_builder.closure_decls != null then
+ for clos in v.signature_builder.closure_decls do
+ prop.signature.closures.add(clos.variable.closure)
+ end
+ end
end
end
end
var isig = ip.signature.adaptation_to(v.local_class.get_type)
if s == null then
- if v.params.length != isig.arity then
+ if v.signature_builder.params.length != isig.arity then
#prop.node.printl("v.params.length {v.params.length} != isig.arity {isig.arity} ; {prop.full_name} vs {ip.full_name}")
return
end
- for p in v.params do
+ for p in v.signature_builder.params do
var t = isig[p.position]
p.stype = t
if p.position == isig.vararg_rank then
if s == null then
#print "{prop.full_name} inherits signature from {ip.full_name}"
- if v.params.length != isig.arity then
+ if v.signature_builder.params.length != isig.arity then
v.error(self, "Redef error: {prop.local_class}::{prop} redefines {ip.local_class}::{ip} with {isig.arity} parameter(s).")
return
end
- for p in v.params do
+ if v.signature_builder.closure_decls.length != isig.closures.length then
+ v.error(self, "Redef error: {prop.local_class}::{prop} redefines {ip.local_class}::{ip} with {isig.arity} closure(s).")
+ return
+ end
+ for p in v.signature_builder.params do
var t = isig[p.position]
p.stype = t
if p.position == isig.vararg_rank then
end
s = isig
prop.signature = s
+ #print "s is null"
end
+ var nberr = v.tc.error_count
+ #print "Check {prop.local_class}::{prop}{s} vs {ip.local_class}::{ip}{isig}"
+ #print "s={s.object_id} isig={isig.object_id} isigorig={i.signature.object_id}"
+
#print "orig signature: {i.signature.recv} . {i.signature}"
#print "inh signature: {isig.recv} . {isig}"
#print "redef signature: {s.recv} . {s}"
- if glob.is_init and i.local_class.global != prop.local_class.global then
- # Do not check signature
- else if s.arity != isig.arity then
+ if s.arity != isig.arity then
v.error(self, "Redef error: {prop.local_class}::{prop} redefines {ip.local_class}::{ip} with {isig.arity} parameter(s).")
else
for i in [0..s.arity[ do
v.error(self, "Redef error: The function {prop.local_class}::{prop} redefines the procedure {ip.local_class}::{ip}.")
else if srt != null and isrt != null and not srt < isrt then
v.error(self, "Redef error: Expected {isrt} (as in {ip.local_class}::{ip}), got {srt} in {prop.local_class}::{prop}.")
+ else if not s < isig and nberr == v.tc.error_count then
+ # Systematic fallback for conformance check
+ v.error(self, "Redef error: Incompatible redefinition of {ip.local_class}::{ip} with {prop.local_class}::{prop}")
else if srt != null and isrt != null and srt != isrt and prop isa MMAttribute then
# FIXME: To remove
v.warning(self, "Redef warning: Expected {isrt} (as in {ip.local_class}::{ip}), got {srt} in {prop.local_class}::{prop}.")
redef meth accept_property_verifier(v)
do
- v.params = new Array[PParam]
- v.untyped_params = new Array[PParam]
- v.signature = null
- v.vararg_rank = -1
-
+ v.signature_builder = new SignatureBuilder
super
- if v.signature == null then
+ if v.signature_builder.signature == null then
#_method.signature = new MMSignature(new Array[MMType], null, v.local_class.get_type)
else
- _method.signature = v.signature
+ _method.signature = v.signature_builder.signature
end
var visibility_level = 1
if n_visibility != null and n_visibility.level > 1 then
# Visitor used to build a full method name from multiple tokens
private class MethidAccumulator
special Visitor
- readable attr _name: String
+ readable attr _name: Buffer = new Buffer
redef meth visit(n)
do
if n isa Token then
n.visit_all(self)
end
end
-
- init
- do
- _name = new String
- end
end
redef class PMethid
do
var accumulator = new MethidAccumulator
accumulator.visit(self)
- _name = accumulator.name.to_symbol
+ _name = accumulator.name.to_s.to_symbol
super
end
end
redef meth accept_property_verifier(v)
do
super
- if not v.untyped_params.is_empty then
- if v.untyped_params.first != v.params.first or n_type != null then
- v.error(v.untyped_params.first, "Syntax error: untyped parameter.")
+ if not v.signature_builder.untyped_params.is_empty then
+ if v.signature_builder.untyped_params.first != v.signature_builder.params.first or n_type != null then
+ v.error(v.signature_builder.untyped_params.first, "Syntax error: untyped parameter.")
return
end
- else if not v.params.is_empty or n_type != null then
+ else if not v.signature_builder.params.is_empty or n_type != null then
var pars = new Array[MMType]
- for p in v.params do
+ for p in v.signature_builder.params do
pars.add(p.stype)
end
var ret: MMType = null
if n_type != null then
ret = n_type.get_stype(v)
end
- v.signature = new MMSignature(pars, ret, v.local_class.get_type)
- if v.vararg_rank >= 0 then
- v.signature.vararg_rank = v.vararg_rank
+ v.signature_builder.signature = new MMSignature(pars, ret, v.local_class.get_type)
+ if v.signature_builder.vararg_rank >= 0 then
+ v.signature_builder.signature.vararg_rank = v.signature_builder.vararg_rank
+ end
+ for clos in v.signature_builder.closure_decls do
+ v.signature_builder.signature.closures.add(clos.variable.closure)
end
end
end
redef class PParam
redef readable attr _position: Int
- redef readable attr _variable: Variable
+ redef readable attr _variable: ParamVariable
# The type of the parameter in signature
readable writable attr _stype: MMType
redef meth accept_property_verifier(v)
do
super
- _position = v.params.length
- _variable = new Variable(n_id.to_symbol, self)
- v.params.add(self)
- v.untyped_params.add(self)
+ _position = v.signature_builder.params.length
+ _variable = new ParamVariable(n_id.to_symbol, self)
+ v.signature_builder.params.add(self)
+ v.signature_builder.untyped_params.add(self)
if n_type != null then
var stype = n_type.get_stype(v)
- for p in v.untyped_params do
+ for p in v.signature_builder.untyped_params do
p.stype = stype
if is_vararg then
- if v.vararg_rank == -1 then
- v.vararg_rank = p.position
+ if v.signature_builder.vararg_rank == -1 then
+ v.signature_builder.vararg_rank = p.position
else
v.error(self, "Error: A vararg parameter is already defined.")
end
end
p.variable.stype = stype
end
- v.untyped_params.clear
+ v.signature_builder.untyped_params.clear
end
end
redef meth is_vararg do return n_dotdotdot != null
end
+redef class AClosureDecl
+ redef readable attr _variable: ClosureVariable
+
+ redef meth accept_property_verifier(v)
+ do
+ var old_signature_builder = v.signature_builder
+ v.signature_builder = new SignatureBuilder
+ super
+ var sig = v.signature_builder.signature
+ if sig == null then
+ sig = new MMSignature(new Array[MMType], null, v.local_class.get_type)
+ end
+ if sig.return_type != null and n_kwbreak != null then
+ v.error(self, "Syntax Error: A break bloc cannot have a return value.")
+ end
+
+ # Add the finalizer to the closure signature
+ var finalize_sig = new MMSignature(new Array[MMType], null, null)
+ var finalizer_clos = new MMClosure(finalize_sig, false, true)
+ sig.closures.add(finalizer_clos)
+
+ var clos = new MMClosure(sig, n_kwbreak != null, n_expr != null)
+ v.signature_builder = old_signature_builder
+ old_signature_builder.closure_decls.add(self)
+ _variable = new ClosureVariable(n_id.to_symbol, self, clos)
+ end
+end
+
redef class PType
# Check that visibilities of types in the signature are compatible with the visibility of the property.
private meth check_visibility(v: AbsSyntaxVisitor, p: MMLocalProperty) is abstract