Merge: Ballz improvements

[nit.git] / contrib / nitrpg / src / achievements.nit

diff --git a/contrib/nitrpg/src/achievements.nit b/contrib/nitrpg/src/achievements.nit
index 99cc0c2..9b18a6b 100644 (file)
--- a/contrib/nitrpg/src/achievements.nit
+++ b/contrib/nitrpg/src/achievements.nit
@@ -97,11 +97,7 @@ class Achievement
        #
        # Used to load achievements from storage.
        init from_json(game: Game, json: JsonObject) do
-               self.game = game
-               id = json["id"].to_s
-               name = json["name"].to_s
-               desc = json["desc"].to_s
-               reward = json["reward"].as(Int)
+               init(game, json["id"].to_s, json["name"].to_s, json["desc"].to_s, json["reward"].as(Int))
        end
 
        redef fun to_json do
@@ -490,7 +486,7 @@ class PlayerFirstReview
        redef fun react_event(game, event) do
                if not event isa IssueCommentEvent then return
                # FIXME use a more precise way to locate reviews
-               if event.comment.has_ok_review then
+               if event.comment.is_ack then
                        var player = event.comment.user.player(game)
                        var a = new_achievement(game)
                        player.unlock_achievement(a, event)