syntax: better location for local variable declarations
[nit.git] / src / syntax / mmbuilder.nit
index af4d0e2..3b7951f 100644 (file)
@@ -42,16 +42,20 @@ redef class MMSrcModule
 
                # Create local classes and attach them to global classes
                var mmbv = new ClassBuilderVisitor(tc, self)
-               mmbv.visit(node)
-               if tc.error_count > 0 then exit(1)
+               mmbv.enter_visit(node)
+               tc.check_errors
+
+               if mhe.direct_greaters.is_empty then
+                       process_default_classes(tc)
+               end
 
                # Import unrefined local classes and attach them to global classes
                import_local_classes
 
                # Resolve classes in super clauses
                var mmbv1 = new ClassSpecializationBuilderVisitor(tc, self)
-               mmbv1.visit(node)
-               if tc.error_count > 0 then exit(1)
+               mmbv1.enter_visit(node)
+               tc.check_errors
 
                # Compute specialization relation
                for c in local_classes do
@@ -60,6 +64,7 @@ redef class MMSrcModule
                        end
                        c.compute_super_classes
                end
+               tc.check_errors
 
                # Class that we will process now are those in the hierarchy
                # Its mean all the visible classes and their super-classes
@@ -74,16 +79,16 @@ redef class MMSrcModule
                var mmbv1b = new ClassAncestorBuilder(tc, self)
                for c in classes do
                        c.accept_class_visitor(mmbv1b)
+                       tc.check_errors
                        c.compute_ancestors
                end
-               if tc.error_count > 0 then exit(1)
 
                # Check class conformity
-               var mmbv1b = new ClassVerifierVisitor(tc, self)
+               var mmbv1c = new ClassVerifierVisitor(tc, self)
                for c in classes do
-                       c.accept_class_visitor(mmbv1b)
+                       c.accept_class_visitor(mmbv1c)
                end
-               if tc.error_count > 0 then exit(1)
+               tc.check_errors
 
                # Property inhritance and introduction
                var mmbv2 = new PropertyBuilderVisitor(tc, self)
@@ -101,7 +106,7 @@ redef class MMSrcModule
 
                        # Note that inherited unredefined property are processed on demand latter
                end
-               if tc.error_count > 0 then exit(1)
+               tc.check_errors
 
                # Property signature analysis and inheritance conformance
                var mmbv3 = new PropertyVerifierVisitor(tc, self)
@@ -117,7 +122,24 @@ redef class MMSrcModule
                        end
                end
 
-               if tc.error_count > 0 then exit(1)
+               tc.check_errors
+       end
+
+       # Create some primitive default classes if they do not exists
+       fun process_default_classes(tc: ToolContext)
+       do
+               var name = once ("Object".to_symbol)
+               if not has_global_class_named(name) then
+                       var c = new MMSrcLocalClass(self, name, null, 0)
+                       c.new_global
+                       src_local_classes[name] = c
+               end
+               name = once ("Bool".to_symbol)
+               if not has_global_class_named(name) then
+                       var c = new MMSrcLocalClass(self, name, null, 0)
+                       c.new_global
+                       src_local_classes[name] = c
+               end
        end
 end
 
@@ -136,16 +158,20 @@ end
 redef class MMSrcLocalClass
        redef fun accept_class_visitor(v)
        do
-               for n in nodes do
-                       v.visit(n)
+               var n = node
+               while n != null do
+                       v.enter_visit(n)
+                       n = n.next_node
                end
        end
 
        # Accept a class visitor (on class properties)
        redef fun accept_properties_visitor(v)
        do
-               for n in nodes do
-                       v.visit(n)
+               var n = node
+               while n != null do
+                       v.enter_visit(n)
+                       n = n.next_node
                end
 
                for p in src_local_properties do
@@ -206,7 +232,7 @@ redef class MMSrcLocalClass
                        var superclass: nullable MMLocalClass = null # This most specific non-mixin superclass (if any)
 
                        if supers.length > 1 then
-                               v.error(nodes.first, "Error: Explicit constructor required in {self} since multiple inheritance of constructor is forbiden. Conflicting classes are {supers.join(", ")}. Costructors are {super_constructors.join(", ")}.")
+                               v.error(node, "Error: Explicit constructor required in {self} since multiple inheritance of constructor is forbiden. Conflicting classes are {supers.join(", ")}. Costructors are {super_constructors.join(", ")}.")
                                return
                        else if supers.length == 1 then
                                superclass = supers.first
@@ -261,7 +287,7 @@ redef class MMLocalProperty
 end
 
 redef class MMImplicitInit
-       readable var _super_init: nullable MMLocalProperty = null
+       redef readable var _super_init: nullable MMLocalProperty = null
        redef fun accept_property_visitor(v)
        do
                var base: nullable MMLocalProperty = null
@@ -297,13 +323,10 @@ end
 # Concrete NIT class specialization relation
 class MMSrcAncestor
 special MMAncestor
-       # The related AST node
-       readable var _node: ASuperclass
        redef readable var _local_class: MMLocalClass
 
-       init(n: ASuperclass, c: MMLocalClass)
+       init(c: MMLocalClass)
        do
-               _node = n
                _local_class = c
        end
 end
@@ -380,10 +403,10 @@ end
 # Information about a signature currently build
 private class SignatureBuilder
        # Current visited parameter types
-       readable writable var _params: Array[PParam] = new Array[PParam]
+       readable writable var _params: Array[AParam] = new Array[AParam]
        
        # Visited parameters without type information added
-       readable writable var _untyped_params: Array[PParam] = new Array[PParam]
+       readable writable var _untyped_params: Array[AParam] = new Array[AParam]
 
        # Position of the current star parameter
        readable writable var _vararg_rank: Int = -1
@@ -391,13 +414,16 @@ private class SignatureBuilder
        # Current closure declarations
        readable writable var _closure_decls: Array[AClosureDecl] = new Array[AClosureDecl]
 
+       # True is a problen occured durring building
+       readable writable var _has_error_occured: Bool = false
+
        # Current signature
        readable writable var _signature: nullable MMSignature = null 
 end
 
 ###############################################################################
 
-redef class PNode
+redef class ANode
        private fun accept_class_builder(v: ClassBuilderVisitor) do accept_abs_syntax_visitor(v)
        private fun accept_class_specialization_builder(v: ClassSpecializationBuilderVisitor) do accept_abs_syntax_visitor(v)
        private fun accept_class_ancestor_builder(v: ClassAncestorBuilder) do accept_abs_syntax_visitor(v)
@@ -413,7 +439,7 @@ redef class AModule
                # Import super-modules
                var module_names_to_import = new Array[Symbol]
                var module_visibility = new HashMap[Symbol, Int]
-               var no_import: nullable PImport = null
+               var no_import: nullable AImport = null
                for i in n_imports do
                        var n = i.module_name
                        if n != null then
@@ -425,7 +451,7 @@ redef class AModule
                end
                if no_import != null then
                        if not module_names_to_import.is_empty then
-                               tc.error("{no_import.locate}: Error: Top modules cannot import other modules.")
+                               tc.error(no_import.location, "Error: Top modules cannot import other modules.")
                        end
                else if module_names_to_import.is_empty then
                        var stdname = once "standard".to_symbol
@@ -452,14 +478,14 @@ redef class APackagedecl
        end
 end
 
-redef class PImport
+redef class AImport
        # Imported module name (or null)
        fun module_name: nullable Symbol is abstract
 
        # Visibility level (intrude/public/private)
        fun visibility_level: Int is abstract
 end
-redef class AImport
+redef class AStdImport
        redef fun module_name
        do
                return n_id.to_symbol
@@ -476,7 +502,7 @@ redef class ANoImport
        end
 end
 
-redef class PVisibility
+redef class AVisibility
        # Visibility level
        fun level: Int is abstract
 end
@@ -494,7 +520,7 @@ redef class AIntrudeVisibility
 end
 
 
-redef class PClassdef
+redef class AClassdef
        redef fun local_class: MMSrcLocalClass do return _local_class.as(not null)
        var _local_class: nullable MMSrcLocalClass
 
@@ -514,12 +540,15 @@ redef class PClassdef
                var local_classes = mod.src_local_classes
                if (local_classes.has_key(name)) then
                        local_class = local_classes[name]
-                       if self isa AClassdef then
+                       if self isa AStdClassdef then
                                # If we are not a special implicit class then rant
-                               v.error(self, "Error: A class {name} is already defined at line {local_class.nodes.first.first_token.line}.")
+                               v.error(self, "Error: A class {name} is already defined at line {local_class.node.location.line_start}.")
                                return
                        end
-                       local_class.nodes.add(self)
+                       # Add the new node after the last node
+                       var n = local_class.node
+                       while n.next_node != null do n = n.next_node
+                       n.next_node = self
                else
                        local_class = new MMSrcLocalClass(mod, name, self, arity)
                        local_classes[name] = local_class
@@ -549,7 +578,7 @@ redef class PClassdef
        end
 end
 
-redef class PClasskind
+redef class AClasskind
        fun is_interface: Bool do return false
        fun is_universal: Bool do return false
        fun is_abstract: Bool do return false
@@ -565,7 +594,7 @@ redef class AAbstractClasskind
        redef fun is_abstract do return true
 end
 
-redef class AClassdef
+redef class AStdClassdef
        redef fun name
        do
                return n_id.to_symbol
@@ -651,26 +680,14 @@ redef class ATopClassdef
        end
 end
 
-class MMSrcTypeFormalParameter
-special MMTypeFormalParameter
-       # The associated node
-       readable var _node: AFormaldef 
-
-       init(name: Symbol, pos: Int, local_class: MMLocalClass, n: AFormaldef)
-       do
-               super(name, pos, local_class)
-               _node = n
-       end
-end
-
 redef class AFormaldef
        # The associated formal generic parameter (MM entity)
-       var _formal: nullable MMSrcTypeFormalParameter
+       var _formal: nullable MMTypeFormalParameter
 
        redef fun accept_class_builder(v)
        do
                var name = n_id.to_symbol
-               var formal_type = new MMSrcTypeFormalParameter(name, v.local_class_arity, v.local_class, self)
+               var formal_type = new MMTypeFormalParameter(name, v.local_class_arity, v.local_class)
                _formal = formal_type
                v.local_class_arity = v.local_class_arity + 1
                v.local_class.register_formal(formal_type)
@@ -687,14 +704,18 @@ redef class AFormaldef
                        if n_type == null then
                                _formal.bound = v.module.type_any.as_nullable
                        else
-                               _formal.bound = n_type.get_stype(v).as(not null)
+                               var stype = n_type.get_stype(v)
+                               if stype == null then return
+                               _formal.bound = stype
                        end
                else
                        var ob = o.get_formal(_formal.position).bound.for_module(v.module)
                        if n_type == null then
                                _formal.bound = ob
                        else
-                               _formal.bound = n_type.get_stype(v).as(not null)
+                               var stype = n_type.get_stype(v)
+                               if stype == null then return
+                               _formal.bound = stype
                                if _formal.bound != ob then
                                        v.error(self, "Redef error: Cannot change formal parameter type of class {c}; got {_formal.bound}, expected {ob}.")
                                end
@@ -711,7 +732,7 @@ redef class ASuperclass
                super
                var c = n_type.get_local_class(v)
                if c == null then return
-               var ancestor = new MMSrcAncestor(self, c)
+               var ancestor = new MMSrcAncestor(c)
                _ancestor = ancestor
                v.local_class.add_direct_parent(ancestor)
        end
@@ -730,7 +751,7 @@ redef class ASuperclass
        end
 end
 
-redef class PPropdef
+redef class APropdef
        # Process and check properties of the property.
        # * Distinguish inits and methods
        # * Inherit or check visibility.
@@ -777,7 +798,7 @@ redef class PPropdef
                                var supers = prop.local_class.super_methods_named(prop.name)
                                inherit_signature(v, prop, supers)
                        end
-                       if prop.signature != null then
+                       if prop.signature != null or v.signature_builder.has_error_occured then
                                # ok
                        else if not v.signature_builder.untyped_params.is_empty then
                                v.error(v.signature_builder.untyped_params.first, "Error: Untyped parameter.")
@@ -798,7 +819,6 @@ redef class PPropdef
 
                        if s == null then
                                if v.signature_builder.params.length != isig.arity then
-                                       #prop.node.printl("v.params.length {v.params.length} != isig.arity {isig.arity} ; {prop.full_name} vs {ip.full_name}")
                                        return
                                end
                                for p in v.signature_builder.params do
@@ -872,9 +892,9 @@ redef class PPropdef
                        if s.arity != isig.arity then
                                v.error(self, "Redef error: {prop.local_class}::{prop} redefines {ip.local_class}::{ip} with {isig.arity} parameter(s).")
                        else
-                               for i in [0..s.arity[ do
-                                       if s[i] != isig[i] then
-                                               v.error(self, "Redef error: Expected {isig[i]} (as in {ip.local_class}::{ip}), got {s[i]} in {prop.local_class}::{prop}.")
+                               for j in [0..s.arity[ do
+                                       if s[j] != isig[j] then
+                                               v.error(self, "Redef error: Expected {isig[j]} (as in {ip.local_class}::{ip}), got {s[j]} in {prop.local_class}::{prop}.")
                                        end
                                end
                        end
@@ -993,7 +1013,7 @@ redef class AMethPropdef
                        # FIXME: Add the 'unary' keyword
                        if n_methid.name == (once "-".to_symbol) then
                                var ns = n_signature
-                               if ns isa ASignature and ns.n_params.length == 0 then
+                               if ns != null and ns.n_params.length == 0 then
                                        name = once "unary -".to_symbol
                                end
                        end
@@ -1009,6 +1029,8 @@ redef class AMethPropdef
                v.signature_builder = new SignatureBuilder
                super
 
+               if v.signature_builder.has_error_occured then return
+
                if v.signature_builder.signature == null then
                        #_method.signature = new MMSignature(new Array[MMType], null, v.local_class.get_type)
                else
@@ -1083,29 +1105,26 @@ special Visitor
        end
 end
 
-redef class PMethid
+redef class AMethid
        # Method name
        readable var _name: nullable Symbol 
 
        redef fun accept_property_builder(v)
        do
                var accumulator = new MethidAccumulator
-               accumulator.visit(self)
+               accumulator.enter_visit(self)
                _name = accumulator.name.to_s.to_symbol
                super
        end
 end
 
-redef class PSignature
-       # Check that visibilities of types in the signature are compatible with the visibility of the property.
-       fun check_visibility(v: AbsSyntaxVisitor, p: MMLocalProperty) is abstract
-end
-
 redef class ASignature
        redef fun accept_property_verifier(v)
        do
                super
-               if not v.signature_builder.untyped_params.is_empty then
+               if v.signature_builder.has_error_occured then
+                       return
+               else if not v.signature_builder.untyped_params.is_empty then
                        if v.signature_builder.untyped_params.first != v.signature_builder.params.first or n_type != null then
                                v.error(v.signature_builder.untyped_params.first, "Syntax error: untyped parameter.")
                                return
@@ -1118,6 +1137,10 @@ redef class ASignature
                        var ret: nullable MMType = null
                        if n_type != null then
                                ret = n_type.get_stype(v)
+                               if ret == null then
+                                       v.signature_builder.has_error_occured = true
+                                       return
+                               end
                        end
                        v.signature_builder.signature = new MMSignature(pars, ret, v.local_class.get_type)
                        if v.signature_builder.vararg_rank >= 0 then
@@ -1129,7 +1152,8 @@ redef class ASignature
                end
        end
 
-       redef fun check_visibility(v, p)
+       # Check that visibilities of types in the signature are compatible with the visibility of the property.
+       fun check_visibility(v: AbsSyntaxVisitor, p: MMLocalProperty)
        do
                if p.global.visibility_level >= 3 then return
                for n in n_params do
@@ -1139,7 +1163,7 @@ redef class ASignature
        end
 end
 
-redef class PParam
+redef class AParam
        redef readable var _position: Int = 0
 
        redef fun variable: ParamVariable do return _variable.as(not null)
@@ -1152,11 +1176,15 @@ redef class PParam
        do
                super
                _position = v.signature_builder.params.length
-               _variable = new ParamVariable(n_id.to_symbol, self)
+               _variable = new ParamVariable(n_id.to_symbol, n_id)
                v.signature_builder.params.add(self)
                v.signature_builder.untyped_params.add(self)
                if n_type != null then
-                       var stype = n_type.get_stype(v).as(not null)
+                       var stype = n_type.get_stype(v)
+                       if stype == null then
+                               v.signature_builder.has_error_occured = true
+                               return
+                       end
                        for p in v.signature_builder.untyped_params do
                                p.stype = stype
                                if is_vararg then
@@ -1173,14 +1201,12 @@ redef class PParam
                end
        end
 
-       fun is_vararg: Bool is abstract
-end
-
-redef class AParam
-       redef fun is_vararg do return n_dotdotdot != null
+       fun is_vararg: Bool do return n_dotdotdot != null
 end
 
 redef class AClosureDecl
+       redef readable var _position: Int = 0
+
        redef fun variable: ClosureVariable do return _variable.as(not null)
        var _variable: nullable ClosureVariable
 
@@ -1189,6 +1215,9 @@ redef class AClosureDecl
                var old_signature_builder = v.signature_builder
                v.signature_builder = new SignatureBuilder
                super
+               if v.signature_builder.has_error_occured then
+                       return
+               end
                var sig = v.signature_builder.signature
                if sig == null then
                        sig = new MMSignature(new Array[MMType], null, v.local_class.get_type)
@@ -1199,23 +1228,27 @@ redef class AClosureDecl
 
                # Add the finalizer to the closure signature
                var finalize_sig = new MMSignature(new Array[MMType], null, v.module.type_any) # FIXME should be no receiver
-               var finalizer_clos = new MMClosure(finalize_sig, false, true)
+               var finalizer_clos = new MMClosure(once ("break".to_symbol), finalize_sig, false, true)
                sig.closures.add(finalizer_clos)
 
-               var clos = new MMClosure(sig, n_kwbreak != null, n_expr != null)
+               var name = n_id.to_symbol
+               var clos = new MMClosure(name, sig, n_kwbreak != null, n_expr != null)
+               for c in old_signature_builder.closure_decls do
+                       if c.n_id.to_symbol == name then
+                               v.error(n_id, "A closure '!{name}' already defined at {c.n_id.location.relative_to(n_id.location)}.")
+                               return
+                       end
+               end
                v.signature_builder = old_signature_builder
+               _position = old_signature_builder.closure_decls.length
                old_signature_builder.closure_decls.add(self)
-               _variable = new ClosureVariable(n_id.to_symbol, self, clos)
+               _variable = new ClosureVariable(n_id.to_symbol, n_id, clos)
        end
 end
 
-redef class PType
-       # Check that visibilities of types in the signature are compatible with the visibility of the property.
-       private fun check_visibility(v: AbsSyntaxVisitor, p: MMLocalProperty) is abstract
-end
-
 redef class AType
-       redef fun check_visibility(v, p)
+       # Check that visibilities of types in the signature are compatible with the visibility of the property.
+       private fun check_visibility(v: AbsSyntaxVisitor, p: MMLocalProperty)
        do
                if p.global.visibility_level >= 3 then return
                var t = get_stype(v)
@@ -1230,7 +1263,7 @@ redef class AType
        end
 end
 
-redef class PExpr
+redef class AExpr
        redef fun accept_class_builder(v) do end
        redef fun accept_property_builder(v) do end
        redef fun accept_property_verifier(v) do end