Merge: nitrpg: remove points if a PR is closed without merge

So @ventilooo won't cheat again!

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

Pull-Request: #1477
Reviewed-by: Jean Privat <jean@pryen.org>
Reviewed-by: ArthurDelamare <arthur.delamare@viacesi.fr>

diff --git a/contrib/nitrpg/src/reactors.nit b/contrib/nitrpg/src/reactors.nit
index 2424d86..7073c98 100644 (file)
--- a/contrib/nitrpg/src/reactors.nit
+++ b/contrib/nitrpg/src/reactors.nit
@@ -74,12 +74,18 @@ redef class PullRequestEvent
        end
 
        private fun react_pull_close(r: PlayerReactor, game: Game) do
-               if not pull.merged then return
                var player = pull.user.player(game)
-               var reward = pull.commits * r.nc_commit_merged
+               var reward
+               var event
+               if pull.merged then
+                       reward = pull.commits * r.nc_commit_merged
+                       event = player_reward_event("pull_merged", player, reward)
+               else
+                       reward = -r.nc_pull_open
+                       event = player_reward_event("pull_closed", player, reward)
+               end
                player.nitcoins += reward
                player.save
-               var event = player_reward_event("pull_merged", player, reward)
                player.add_event(event)
        end
 end