github: GithubWallet uses optional attributes

Signed-off-by: Alexandre Terrasa <alexandre@moz-code.org>

diff --git a/lib/github/loader.nit b/lib/github/loader.nit
index c20529b..b5fd29b 100644 (file)
--- a/lib/github/loader.nit
+++ b/lib/github/loader.nit
@@ -120,7 +120,7 @@ class LoaderConfig
 
        # Github tokens wallet\13
        var wallet: GithubWallet is lazy do
-               var wallet = new GithubWallet.from_tokens(tokens)
+               var wallet = new GithubWallet(tokens)
                wallet.no_colors = no_colors
                return wallet
        end

diff --git a/lib/github/tests/test_wallet.nit b/lib/github/tests/test_wallet.nit
index d4d2c4d..e38c1d7 100644 (file)
--- a/lib/github/tests/test_wallet.nit
+++ b/lib/github/tests/test_wallet.nit
@@ -46,7 +46,7 @@ class TestGithubWallet
        test
 
        fun test_get_next_token is test do
-               var wallet = new GithubWallet.from_tokens(["t1", "t2", "t3"])
+               var wallet = new GithubWallet(["t1", "t2", "t3"])
 
                for j in [1..3] do
                        for i in [1..3] do assert wallet.get_next_token == "t{i}"
@@ -60,7 +60,7 @@ class TestGithubWallet
        end
 
        fun test_get_api is test do
-               var wallet = new GithubWallet.from_tokens(["bad1", "t1", "t2", "bad2"])
+               var wallet = new GithubWallet(["bad1", "t1", "t2", "bad2"])
                assert wallet.api.auth == "t1"
                assert wallet.api.auth == "t2"
                assert wallet.api.auth == "t1"

diff --git a/lib/github/wallet.nit b/lib/github/wallet.nit
index 68dc166..4737410 100644 (file)
--- a/lib/github/wallet.nit
+++ b/lib/github/wallet.nit
@@ -45,7 +45,7 @@
 # or
 #
 # ~~~
-# wallet = new GithubWallet.from_tokens(["token 1", "token 2"])
+# wallet = new GithubWallet(["token 1", "token 2"])
 # ~~~
 #
 # The `show_status` method can be used to display a summary of the validity of
@@ -69,7 +69,7 @@
 # instance with a fresh rate limit.
 #
 # ~~~
-# wallet = new GithubWallet.from_tokens(["token 1", "token 2"])
+# wallet = new GithubWallet(["token 1", "token 2"])
 # var api = wallet.api
 # ~~~
 #
@@ -87,10 +87,7 @@ import console
 class GithubWallet
 
        # Github API tokens
-       var tokens = new Array[String]
-
-       # Init `self` from a collection of tokens
-       init from_tokens(tokens: Collection[String]) do self.tokens.add_all tokens
+       var tokens = new Array[String] is optional
 
        # Do not use colors in console output
        var no_colors = false is writable