syntax: merge nullable information on type evolution
authorJean Privat <jean@pryen.org>
Fri, 8 Jan 2010 19:45:57 +0000 (14:45 -0500)
committerJean Privat <jean@pryen.org>
Thu, 14 Jan 2010 16:43:41 +0000 (11:43 -0500)
Signed-off-by: Jean Privat <jean@pryen.org>

19 files changed:
src/syntax/control_flow.nit
tests/base_var_type_evolution.nit [new file with mode: 0644]
tests/base_var_type_evolution_null.nit [new file with mode: 0644]
tests/sav/base_var_type_evolution.sav [new file with mode: 0644]
tests/sav/base_var_type_evolution_alt1.sav [new file with mode: 0644]
tests/sav/base_var_type_evolution_alt2.sav [new file with mode: 0644]
tests/sav/base_var_type_evolution_alt3.sav [new file with mode: 0644]
tests/sav/base_var_type_evolution_alt4.sav [new file with mode: 0644]
tests/sav/base_var_type_evolution_alt5.sav [new file with mode: 0644]
tests/sav/base_var_type_evolution_alt6.sav [new file with mode: 0644]
tests/sav/base_var_type_evolution_alt7.sav [new file with mode: 0644]
tests/sav/base_var_type_evolution_null.sav [new file with mode: 0644]
tests/sav/base_var_type_evolution_null_alt1.sav [new file with mode: 0644]
tests/sav/base_var_type_evolution_null_alt2.sav [new file with mode: 0644]
tests/sav/base_var_type_evolution_null_alt3.sav [new file with mode: 0644]
tests/sav/base_var_type_evolution_null_alt4.sav [new file with mode: 0644]
tests/sav/base_var_type_evolution_null_alt5.sav [new file with mode: 0644]
tests/sav/base_var_type_evolution_null_alt6.sav [new file with mode: 0644]
tests/sav/base_var_type_evolution_null_alt7.sav [new file with mode: 0644]

index 2c7e691..b0b1d9e 100644 (file)
@@ -164,18 +164,47 @@ abstract class VariableContext
                        var s2 = ctx2.stype(v)
                        if s1 == s and s2 == s then
                                # NOP
-                       else if s1 == s2 then
-                               stype(v) = s1
-                       else if s2 == null or s1 < s2 then
-                               stype(v) = s2
-                       else if s1 == null or s2 < s1 then
-                               stype(v) = s1
+                       else if s1 == null or s2 == null then
+                               stype(v) = null
                        else
-                               stype(v) = basectx.stype(v)
+                               var sm = merge_types(s1, s2)
+                               if sm == null then
+                                       stype(v) = basectx.stype(v)
+                               else
+                                       stype(v) = sm
+                               end
                        end
                end
        end
 
+       # Combine and get the most specific comon supertype
+       # return null if no comon supertype is found
+       private fun merge_types(t1, t2: MMType): nullable MMType
+       do
+               if t1 == t2 then return t1
+               if t1 isa MMTypeNone then return t2.as_nullable
+               if t2 isa MMTypeNone then return t1.as_nullable
+               var is_nullable = false
+               if t1.is_nullable then
+                       is_nullable = true
+                       t1 = t1.as_notnull
+               end
+               if t2.is_nullable then
+                       is_nullable = true
+                       t2 = t2.as_notnull
+               end
+               var t: MMType
+               if t1 < t2 then
+                       t = t2
+               else if t2 < t1 then
+                       t = t1
+               else
+                       return null
+               end
+               if is_nullable then t = t.as_nullable
+               return t
+       end
+
        redef fun to_s
        do
                var s = new Buffer
diff --git a/tests/base_var_type_evolution.nit b/tests/base_var_type_evolution.nit
new file mode 100644 (file)
index 0000000..f62d58e
--- /dev/null
@@ -0,0 +1,76 @@
+# This file is part of NIT ( http://www.nitlanguage.org ).
+#
+# Copyright 2010 Jean Privat <jean@pryen.org>
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import kernel
+
+class A
+       fun a do 'A'.output
+end
+
+class B
+special A
+       fun b do 'B'.output
+end
+
+class C
+special A
+       fun c do 'C'.output
+end
+
+fun rand: Bool do return true
+
+var a = new A
+if rand then
+       a = new B
+end
+a.a
+#alt1#a.b
+'\n'.output
+
+a = new B
+if rand then
+       a = new B
+       #alt2#a = new C
+       #alt3#a = new A
+end
+a.a
+a.b
+'\n'.output
+
+a = new A
+if rand then
+       a = new B
+       #alt4#a = new C
+else
+       a = new B
+       #alt5#a = new C
+end
+a.a
+a.b
+'\n'.output
+
+a = new A
+if rand then
+       a = new B
+else
+       a = new C
+       abort#!alt6#
+end
+a.a
+a.b
+#alt7#a.c
+'\n'.output
+
diff --git a/tests/base_var_type_evolution_null.nit b/tests/base_var_type_evolution_null.nit
new file mode 100644 (file)
index 0000000..15012e7
--- /dev/null
@@ -0,0 +1,66 @@
+# This file is part of NIT ( http://www.nitlanguage.org ).
+#
+# Copyright 2010 Jean Privat <jean@pryen.org>
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import kernel
+
+class A
+end
+
+class B
+special A
+end
+
+fun rand: Bool do return true
+
+fun eat_na(a: nullable A) do 'a'.output
+fun eat_a(a: A) do 'A'.output
+fun eat_nb(b: nullable B) do 'b'.output
+fun eat_b(b: B) do 'B'.output
+
+var a: nullable Object = null
+a = new B
+if rand then
+       a = null #!alt1#
+       #alt2#a = new A
+       #alt3#a = new B
+end
+eat_na(a)
+#alt2#eat_a(a)
+eat_nb(a)
+#alt1#eat_b(a)
+#alt3#eat_b(a)
+#alt4#eat_b(a)
+'\n'.output
+
+# a is 'nullable B' here
+if rand then
+       a = new A
+end
+eat_na(a)
+#alt5#eat_a(a)
+#alt6#eat_nb(a)
+'\n'.output
+# a is 'nullable A' here
+
+if rand then
+       a = new B
+else
+       a = new B
+       #alt7#a = new A
+end
+eat_b(a)
+'\n'.output
+
diff --git a/tests/sav/base_var_type_evolution.sav b/tests/sav/base_var_type_evolution.sav
new file mode 100644 (file)
index 0000000..f9599ad
--- /dev/null
@@ -0,0 +1,4 @@
+A
+AB
+AB
+AB
diff --git a/tests/sav/base_var_type_evolution_alt1.sav b/tests/sav/base_var_type_evolution_alt1.sav
new file mode 100644 (file)
index 0000000..f8f0bc8
--- /dev/null
@@ -0,0 +1 @@
+alt/base_var_type_evolution_alt1.nit:40,1--3: Error: Method 'b' doesn't exists in A.
diff --git a/tests/sav/base_var_type_evolution_alt2.sav b/tests/sav/base_var_type_evolution_alt2.sav
new file mode 100644 (file)
index 0000000..9c711bb
--- /dev/null
@@ -0,0 +1 @@
+alt/base_var_type_evolution_alt2.nit:50,1--3: Error: Method 'b' doesn't exists in A.
diff --git a/tests/sav/base_var_type_evolution_alt3.sav b/tests/sav/base_var_type_evolution_alt3.sav
new file mode 100644 (file)
index 0000000..68c434b
--- /dev/null
@@ -0,0 +1 @@
+alt/base_var_type_evolution_alt3.nit:50,1--3: Error: Method 'b' doesn't exists in A.
diff --git a/tests/sav/base_var_type_evolution_alt4.sav b/tests/sav/base_var_type_evolution_alt4.sav
new file mode 100644 (file)
index 0000000..b71b085
--- /dev/null
@@ -0,0 +1 @@
+alt/base_var_type_evolution_alt4.nit:62,1--3: Error: Method 'b' doesn't exists in A.
diff --git a/tests/sav/base_var_type_evolution_alt5.sav b/tests/sav/base_var_type_evolution_alt5.sav
new file mode 100644 (file)
index 0000000..b33dce3
--- /dev/null
@@ -0,0 +1 @@
+alt/base_var_type_evolution_alt5.nit:62,1--3: Error: Method 'b' doesn't exists in A.
diff --git a/tests/sav/base_var_type_evolution_alt6.sav b/tests/sav/base_var_type_evolution_alt6.sav
new file mode 100644 (file)
index 0000000..4b62222
--- /dev/null
@@ -0,0 +1 @@
+alt/base_var_type_evolution_alt6.nit:72,1--3: Error: Method 'b' doesn't exists in A.
diff --git a/tests/sav/base_var_type_evolution_alt7.sav b/tests/sav/base_var_type_evolution_alt7.sav
new file mode 100644 (file)
index 0000000..98cc679
--- /dev/null
@@ -0,0 +1 @@
+alt/base_var_type_evolution_alt7.nit:74,1--3: Error: Method 'c' doesn't exists in B.
diff --git a/tests/sav/base_var_type_evolution_null.sav b/tests/sav/base_var_type_evolution_null.sav
new file mode 100644 (file)
index 0000000..9fe5e39
--- /dev/null
@@ -0,0 +1,3 @@
+ab
+a
+B
diff --git a/tests/sav/base_var_type_evolution_null_alt1.sav b/tests/sav/base_var_type_evolution_null_alt1.sav
new file mode 100644 (file)
index 0000000..4827767
--- /dev/null
@@ -0,0 +1,3 @@
+abB
+a
+B
diff --git a/tests/sav/base_var_type_evolution_null_alt2.sav b/tests/sav/base_var_type_evolution_null_alt2.sav
new file mode 100644 (file)
index 0000000..2f46251
--- /dev/null
@@ -0,0 +1 @@
+alt/base_var_type_evolution_null_alt2.nit:42,8: Type error: expected nullable B, got A
diff --git a/tests/sav/base_var_type_evolution_null_alt3.sav b/tests/sav/base_var_type_evolution_null_alt3.sav
new file mode 100644 (file)
index 0000000..4827767
--- /dev/null
@@ -0,0 +1,3 @@
+abB
+a
+B
diff --git a/tests/sav/base_var_type_evolution_null_alt4.sav b/tests/sav/base_var_type_evolution_null_alt4.sav
new file mode 100644 (file)
index 0000000..db67a84
--- /dev/null
@@ -0,0 +1 @@
+alt/base_var_type_evolution_null_alt4.nit:45,7: Type error: expected B, got nullable B
diff --git a/tests/sav/base_var_type_evolution_null_alt5.sav b/tests/sav/base_var_type_evolution_null_alt5.sav
new file mode 100644 (file)
index 0000000..bd4b700
--- /dev/null
@@ -0,0 +1 @@
+alt/base_var_type_evolution_null_alt5.nit:53,7: Type error: expected A, got nullable A
diff --git a/tests/sav/base_var_type_evolution_null_alt6.sav b/tests/sav/base_var_type_evolution_null_alt6.sav
new file mode 100644 (file)
index 0000000..f759dfe
--- /dev/null
@@ -0,0 +1 @@
+alt/base_var_type_evolution_null_alt6.nit:54,8: Type error: expected nullable B, got nullable A
diff --git a/tests/sav/base_var_type_evolution_null_alt7.sav b/tests/sav/base_var_type_evolution_null_alt7.sav
new file mode 100644 (file)
index 0000000..1867feb
--- /dev/null
@@ -0,0 +1 @@
+alt/base_var_type_evolution_null_alt7.nit:64,7: Type error: expected B, got A