opts: error when lack of a mandatory parameter

Signed-off-by: Alexandre Pennetier <alexandre.pennetier@me.com>

diff --git a/lib/opts.nit b/lib/opts.nit
index db931d6..44571c8 100644 (file)
--- a/lib/opts.nit
+++ b/lib/opts.nit
@@ -123,23 +123,34 @@ class OptionCount
        end
 end
 
-# Option with one mandatory parameter
+# Option with one parameter (mandatory by default)
 abstract class OptionParameter
        super Option
        protected fun convert(str: String): VALUE is abstract
 
+       # Is the parameter mandatory?
+       readable writable var _parameter_mandatory: Bool
+
        redef fun read_param(it)
        do
                super
-               if it.is_ok then
+               if it.is_ok and it.item.first != '-' then
                        value = convert(it.item)
                        it.next
                else
-                       # TODO: What to do?
+                       if _parameter_mandatory then
+                               # FIXME exit(1) is not a good way of handling the error
+                               stderr.write("Error: parameter expected for option {names.first}\n")
+                               exit(1)
+                       end
                end
        end
 
-       init init_opt(h, d, n) do super
+       init init_opt(h, d, n)
+       do
+               super
+               _parameter_mandatory = true
+       end
 end
 
 class OptionString