rta: resolve the open-types in a depth-first order to reach limit faster
[nit.git] / src / rapid_type_analysis.nit
1 # This file is part of NIT ( http://www.nitlanguage.org ).
2 #
3 # Copyright 2012 Jean Privat <jean@pryen.org>
4 #
5 # Licensed under the Apache License, Version 2.0 (the "License");
6 # you may not use this file except in compliance with the License.
7 # You may obtain a copy of the License at
8 #
9 # http://www.apache.org/licenses/LICENSE-2.0
10 #
11 # Unless required by applicable law or agreed to in writing, software
12 # distributed under the License is distributed on an "AS IS" BASIS,
13 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14 # See the License for the specific language governing permissions and
15 # limitations under the License.
16
17
18 # Rapid type analysis on the AST
19 #
20 # Rapid type analysis is an analyse that aproximates the set of live classes
21 # and the set of live methods starting from the entry point of the program.
22 # These two sets are interdependant and computed together.
23 # It is quite efficient but the type set is global and pollutes each call site.
24 module rapid_type_analysis
25
26 import semantize
27
28 import csv # for live_types_to_csv
29 private import ordered_tree # for live_methods_to_tree
30
31 private import more_collections
32
33 redef class ModelBuilder
34 # Performs a rapid-type-analysis on the program associated with `mainmodule`.
35 fun do_rapid_type_analysis(mainmodule: MModule): RapidTypeAnalysis
36 do
37 var analysis = new RapidTypeAnalysis(self, mainmodule)
38 analysis.run_analysis
39
40 if toolcontext.opt_log.value then
41 var basename = toolcontext.log_directory / mainmodule.name
42 analysis.live_methods_to_tree.write_to_file(basename + ".rta_methods.txt")
43 analysis.live_types_to_csv.write_to_file(basename + ".rta_types.csv")
44 end
45
46 return analysis
47 end
48 end
49
50 # RapidTypeAnalysis looks for alive rapid types in application.
51 # The entry point of the analysis is the mainmodule of the application.
52 class RapidTypeAnalysis
53 # The modelbuilder used to get the AST.
54 var modelbuilder: ModelBuilder
55
56 # The main module of the analysis.
57 # Used to perform types operations.
58 var mainmodule: MModule
59
60 # The pool to live types.
61 # During the analysis, new types are added and combined with
62 # live_methods to determine new methoddefs to visit
63 var live_types = new HashSet[MClassType]
64
65 # The pool of undesolved live types
66 # They are globally resolved at the end of the analaysis
67 var live_open_types = new HashSet[MClassType]
68
69 # Live (instantiated) classes.
70 var live_classes = new HashSet[MClass]
71
72 # The pool of types used to perform type checks (isa and as).
73 var live_cast_types = new HashSet[MType]
74
75 # The pool of undesolved types used to perform type checks (isa and as).
76 # They are globally resolved at the end of the analaysis
77 var live_open_cast_types = new HashSet[MType]
78
79 # Live method definitions.
80 var live_methoddefs = new HashSet[MMethodDef]
81
82 # Live methods.
83 var live_methods = new HashSet[MMethod]
84
85 # Live mmodules.
86 # Those with a live method definitions (see `live_methoddefs`)
87 var live_mmodules = new HashSet[MModule]
88
89 # Live callsites.
90 var live_callsites = new HashSet[CallSite]
91
92 private var live_targets_cache = new HashMap2[MType, MProperty, Set[MMethodDef]]
93
94 # The live targets of a specific callsite.
95 fun live_targets(callsite: CallSite): Set[MMethodDef]
96 do
97 var mtype = callsite.recv
98 var anchor = callsite.anchor
99 if anchor != null then mtype = mtype.anchor_to(callsite.mmodule, anchor)
100 mtype = mtype.undecorate
101 if mtype isa MClassType then mtype = mtype.mclass.intro.bound_mtype
102 var mproperty = callsite.mproperty
103 var res = live_targets_cache[mtype, mproperty]
104 if res != null then return res
105 res = new ArraySet[MMethodDef]
106 live_targets_cache[mtype, mproperty] = res
107
108 for c in live_classes do
109 var tc = c.intro.bound_mtype
110 if not tc.is_subtype(mainmodule, null, mtype) then continue
111 var d = mproperty.lookup_first_definition(mainmodule, tc)
112 res.add d
113 end
114
115 return res
116 end
117
118 # Live call-to-super.
119 var live_super_sends = new HashSet[MMethodDef]
120
121 # Return a ready-to-save CSV document objet that agregates informations about live types.
122 # Each discovered type is listed in a line, with its status: resolution, liveness, cast-liveness.
123 # Note: types are listed in an alphanumeric order to improve human reading.
124 fun live_types_to_csv: CsvDocument
125 do
126 # Gather all kind of type
127 var typeset = new HashSet[MType]
128 typeset.add_all(live_types)
129 typeset.add_all(live_open_types)
130 typeset.add_all(live_cast_types)
131 typeset.add_all(live_open_cast_types)
132 var types = typeset.to_a
133 (new CachedAlphaComparator).sort(types)
134 var res = new CsvDocument
135 res.separator = ';'
136 res.header = ["Type", "Resolution", "Liveness", "Cast-liveness"]
137 for t in types do
138 var reso
139 if t.need_anchor then reso = "OPEN " else reso = "CLOSED"
140 var live
141 if t isa MClassType and (live_types.has(t) or live_open_types.has(t)) then live = "LIVE" else live = "DEAD"
142 var cast
143 if live_cast_types.has(t) or live_open_cast_types.has(t) then cast = "CAST LIVE" else cast = "CAST DEAD"
144 res.add_record(t, reso, live, cast)
145 end
146 return res
147 end
148
149 # Return a ready-to-save OrderedTree object that agregates infomration about live methods.
150 # Note: methods are listed in an alphanumeric order to improve human reading.
151 fun live_methods_to_tree: OrderedTree[Object]
152 do
153 var tree = new OrderedTree[Object]
154 for x in live_methods do
155 var xn = x.full_name
156 tree.add(null, xn)
157 for z in x.mpropdefs do
158 var zn = z.to_s
159 if live_methoddefs.has(z) then
160 tree.add(xn, zn)
161 if live_super_sends.has(z) then
162 tree.add(zn, zn + "(super)")
163 end
164 else if live_super_sends.has(z) then
165 tree.add(xn, zn + "(super)")
166 end
167 end
168 end
169 tree.sort_with(alpha_comparator)
170 return tree
171 end
172
173 # Methods that are still candidate to the try_send
174 private var totry_methods = new HashSet[MMethod]
175
176 # Methods that are are no more candidate to the try_send
177 private var totry_methods_to_remove = new Array[MMethod]
178
179 # Methods that are or were candidate to the try_send
180 # Used to ensure that try_send is only used once
181 private var try_methods = new HashSet[MMethod]
182
183 # The method definitions that remain to visit
184 private var todo = new List[MMethodDef]
185
186 private fun force_alive(classname: String)
187 do
188 var classes = self.modelbuilder.model.get_mclasses_by_name(classname)
189 if classes != null then for c in classes do self.add_new(c.mclass_type, c.mclass_type)
190 end
191
192 # Run the analysis until all visitable method definitions are visited.
193 fun run_analysis
194 do
195 var maintype = mainmodule.sys_type
196 if maintype == null then return # No entry point
197 add_new(maintype, maintype)
198 var initprop = mainmodule.try_get_primitive_method("init", maintype.mclass)
199 if initprop != null then
200 add_send(maintype, initprop)
201 end
202 var mainprop = mainmodule.try_get_primitive_method("run", maintype.mclass) or else
203 mainmodule.try_get_primitive_method("main", maintype.mclass)
204 if mainprop != null then
205 add_send(maintype, mainprop)
206 end
207
208 var finalizable_type = mainmodule.finalizable_type
209 if finalizable_type != null then
210 var finalize_meth = mainmodule.try_get_primitive_method("finalize", finalizable_type.mclass)
211 if finalize_meth != null then add_send(finalizable_type, finalize_meth)
212 end
213
214 # Force primitive types
215 force_alive("Bool")
216 force_alive("Float")
217 force_alive("Char")
218 force_alive("Pointer")
219 force_alive("Byte")
220 force_alive("Int")
221 force_alive("Int8")
222 force_alive("Int16")
223 force_alive("UInt16")
224 force_alive("Int32")
225 force_alive("UInt32")
226
227 while not todo.is_empty do
228 var mmethoddef = todo.shift
229 var mmeth = mmethoddef.mproperty
230 var msignature = mmethoddef.msignature
231 if msignature == null then continue # Skip broken method
232
233 #print "# visit {mmethoddef}"
234 var v = new RapidTypeVisitor(self, mmethoddef.mclassdef.bound_mtype, mmethoddef)
235
236 var vararg_rank = msignature.vararg_rank
237 if vararg_rank > -1 then
238 var node = self.modelbuilder.mpropdef2node(mmethoddef)
239 var elttype = msignature.mparameters[vararg_rank].mtype
240 #elttype = elttype.anchor_to(self.mainmodule, v.receiver)
241 var vararg = self.mainmodule.array_type(elttype)
242 v.add_type(vararg)
243 var native = self.mainmodule.native_array_type(elttype)
244 v.add_type(native)
245 v.add_monomorphic_send(vararg, self.modelbuilder.force_get_primitive_method(node, "with_native", vararg.mclass, self.mainmodule))
246 end
247
248 # TODO? new_msignature
249 var sig = msignature
250 var osig = mmeth.intro.msignature.as(not null)
251 for i in [0..sig.arity[ do
252 var origtype = osig.mparameters[i].mtype
253 if not origtype.need_anchor then continue # skip non covariant stuff
254 var paramtype = sig.mparameters[i].mtype
255 add_cast(paramtype)
256 end
257
258 var npropdef = modelbuilder.mpropdef2node(mmethoddef)
259
260 if npropdef isa AClassdef then
261 if mmethoddef.mproperty.is_root_init then
262 if not mmethoddef.is_intro then
263 self.add_super_send(v.receiver, mmethoddef)
264 end
265 else
266 npropdef.debug "cannot RTA {mmethoddef}"
267 abort
268 end
269 continue
270 else if mmethoddef.constant_value != null then
271 # Make the return type live
272 v.add_type(msignature.return_mtype.as(MClassType))
273 continue
274 else if npropdef == null then
275 abort
276 end
277
278 if npropdef isa AMethPropdef then
279 var auto_super_inits = npropdef.auto_super_inits
280 if auto_super_inits != null then
281 for auto_super_init in auto_super_inits do
282 v.add_callsite(auto_super_init)
283 end
284 end
285 if npropdef.auto_super_call then
286 self.add_super_send(v.receiver, mmethoddef)
287 end
288 end
289
290 if mmethoddef.is_intern or mmethoddef.is_extern then
291 # UGLY: We force the "instantation" of the concrete return type if any
292 var ret = msignature.return_mtype
293 if ret != null and ret isa MClassType and ret.mclass.kind != abstract_kind and ret.mclass.kind != interface_kind then
294 v.add_type(ret)
295 end
296 end
297
298 v.enter_visit(npropdef)
299 end
300
301 #print "MMethod {live_methods.length}: {live_methods.join(", ")}"
302 #print "MMethodDef {live_methoddefs.length}: {live_methoddefs.join(", ")}"
303
304 #print "open MType {live_open_types.length}: {live_open_types.join(", ")}"
305 var todo_types = new List[MClassType]
306 todo_types.add_all(live_types)
307 while not todo_types.is_empty do
308 var t = todo_types.shift
309 for ot in live_open_types do
310 #print "{ot}/{t} ?"
311 if not ot.can_resolve_for(t, t, mainmodule) then continue
312 var rt = ot.anchor_to(mainmodule, t)
313 if live_types.has(rt) then continue
314 if not check_depth(rt) then continue
315 #print "{ot}/{t} -> {rt}"
316 live_types.add(rt)
317 # unshift means a deep-first visit.
318 # So that the `check_depth` limit is reached sooner.
319 todo_types.unshift(rt)
320 end
321 end
322 #print "MType {live_types.length}: {live_types.join(", ")}"
323
324 #print "open cast MType {live_open_cast_types.length}: {live_open_cast_types.join(", ")}"
325 for ot in live_open_cast_types do
326 #print "live_open_cast_type: {ot}"
327 for t in live_types do
328 if not ot.can_resolve_for(t, t, mainmodule) then continue
329 var rt = ot.anchor_to(mainmodule, t)
330 live_cast_types.add(rt)
331 #print " {ot}/{t} -> {rt}"
332 end
333 end
334 #print "cast MType {live_cast_types.length}: {live_cast_types.join(", ")}"
335 end
336
337 private fun check_depth(mtype: MClassType): Bool
338 do
339 var d = mtype.length
340 if d > 255 then
341 self.modelbuilder.toolcontext.fatal_error(null, "Fatal Error: limitation in the rapidtype analysis engine: a type depth of {d} is too important, the problematic type is `{mtype}`.")
342 return false
343 end
344 return true
345 end
346
347 fun add_new(recv: MClassType, mtype: MClassType)
348 do
349 assert not recv.need_anchor
350 if mtype.need_anchor then
351 if live_open_types.has(mtype) then return
352 live_open_types.add(mtype)
353 else
354 if live_types.has(mtype) then return
355 live_types.add(mtype)
356 end
357
358 var mclass = mtype.mclass
359 if live_classes.has(mclass) then return
360 live_classes.add(mclass)
361
362 for p in totry_methods do try_send(mtype, p)
363 for p in live_super_sends do try_super_send(mtype, p)
364
365 # Remove cleared ones
366 for p in totry_methods_to_remove do totry_methods.remove(p)
367 totry_methods_to_remove.clear
368
369 var bound_mtype = mtype.anchor_to(mainmodule, recv)
370 for cd in bound_mtype.collect_mclassdefs(mainmodule)
371 do
372 for npropdef in modelbuilder.collect_attr_propdef(cd) do
373 if not npropdef.has_value then continue
374
375 var mpropdef = npropdef.mreadpropdef.as(not null)
376 var v = new RapidTypeVisitor(self, bound_mtype, mpropdef)
377 v.enter_visit(npropdef.n_expr)
378 v.enter_visit(npropdef.n_block)
379 end
380 end
381
382 end
383
384 fun add_cast(mtype: MType)
385 do
386 if mtype.need_anchor then
387 live_open_cast_types.add(mtype)
388 else
389 live_cast_types.add(mtype)
390 end
391 end
392
393 fun try_send(recv: MClassType, mproperty: MMethod)
394 do
395 recv = recv.mclass.intro.bound_mtype
396 if not recv.has_mproperty(mainmodule, mproperty) then return
397 var d = mproperty.lookup_first_definition(mainmodule, recv)
398 add_call(d)
399 end
400
401 fun add_call(mpropdef: MMethodDef)
402 do
403 if live_methoddefs.has(mpropdef) then return
404 live_methoddefs.add(mpropdef)
405 live_mmodules.add(mpropdef.mclassdef.mmodule)
406 todo.add(mpropdef)
407
408 var mproperty = mpropdef.mproperty
409 if mproperty.mpropdefs.length <= 1 then return
410 # If all definitions of a method are live, we can remove the definition of the totry set
411 for d in mproperty.mpropdefs do
412 if not live_methoddefs.has(d) then return
413 end
414 #print "full property: {mpropdef.mproperty} for {mpropdef.mproperty.mpropdefs.length} definitions"
415 totry_methods_to_remove.add(mpropdef.mproperty)
416 end
417
418 fun add_send(recv: MType, mproperty: MMethod)
419 do
420 if try_methods.has(mproperty) then return
421 #print "new prop: {mproperty}"
422 live_methods.add(mproperty)
423 try_methods.add(mproperty)
424 if mproperty.mpropdefs.length == 1 then
425 # If there is only one definition, just add the definition and do not try again the property
426 var d = mproperty.mpropdefs.first
427 add_call(d)
428 return
429 end
430 # Else, the property is potentially called with various reciever
431 # So just try the methods with existing receiver and register it for future receiver
432 totry_methods.add(mproperty)
433 for c in live_classes do
434 try_send(c.intro.bound_mtype, mproperty)
435 end
436 end
437
438 fun try_super_send(recv: MClassType, mpropdef: MMethodDef)
439 do
440 recv = recv.mclass.intro.bound_mtype
441 if not recv.collect_mclassdefs(mainmodule).has(mpropdef.mclassdef) then return
442 var d = mpropdef.lookup_next_definition(mainmodule, recv)
443 add_call(d)
444 end
445
446 fun add_super_send(recv: MType, mpropdef: MMethodDef)
447 do
448 assert mpropdef.has_supercall
449 if live_super_sends.has(mpropdef) then return
450 #print "new super prop: {mpropdef}"
451 live_super_sends.add(mpropdef)
452 for c in live_classes do
453 try_super_send(c.intro.bound_mtype, mpropdef)
454 end
455 end
456 end
457
458 class RapidTypeVisitor
459 super Visitor
460
461 var analysis: RapidTypeAnalysis
462 var receiver: MClassType
463 var mpropdef: MPropDef
464
465 init
466 do
467 assert not receiver.need_anchor
468 end
469
470 redef fun visit(n)
471 do
472 if n isa AExpr then
473 if n.mtype != null or n.is_typed then
474 n.accept_rapid_type_visitor(self)
475 var implicit_cast_to = n.implicit_cast_to
476 if implicit_cast_to != null then self.add_cast_type(implicit_cast_to)
477 end
478 else
479 n.accept_rapid_type_visitor(self)
480 end
481
482 # RTA does not enter in AAnnotations
483 if not n isa AAnnotations then
484 n.visit_all(self)
485 end
486 end
487
488 fun cleanup_type(mtype: MType): nullable MClassType
489 do
490 mtype = mtype.anchor_to(self.analysis.mainmodule, self.receiver)
491 if mtype isa MNullType then return null
492 mtype = mtype.undecorate
493 assert mtype isa MClassType
494 assert not mtype.need_anchor
495 return mtype
496 end
497
498 fun get_method(recv: MType, name: String): MMethod
499 do
500 var mtype = cleanup_type(recv)
501 assert mtype != null
502 return self.analysis.modelbuilder.force_get_primitive_method(self.current_node.as(not null), name, mtype.mclass, self.analysis.mainmodule)
503 end
504
505 fun add_type(mtype: MClassType) do analysis.add_new(receiver, mtype)
506
507 fun add_monomorphic_send(mtype: MType, mproperty: MMethod)
508 do
509 analysis.live_methods.add(mproperty)
510 analysis.try_send(mtype.as(MClassType), mproperty)
511 end
512
513 fun add_send(mtype: MType, mproperty: MMethod) do analysis.add_send(mtype, mproperty)
514
515 fun add_cast_type(mtype: MType) do analysis.add_cast(mtype)
516
517 fun add_callsite(callsite: nullable CallSite) do if callsite != null then
518 for m in callsite.mpropdef.initializers do
519 if m isa MMethod then
520 analysis.add_send(callsite.recv, m)
521 end
522 end
523 analysis.add_send(callsite.recv, callsite.mproperty)
524 analysis.live_callsites.add(callsite)
525 end
526 end
527
528 ###
529
530 redef class ANode
531 private fun accept_rapid_type_visitor(v: RapidTypeVisitor)
532 do
533 end
534 end
535
536 redef class AExpr
537 # Make the `mtype` of the expression live
538 # Used by literals and instantiations
539 fun allocate_mtype(v: RapidTypeVisitor)
540 do
541 var mtype = self.mtype
542 if not mtype isa MClassType then return
543 v.add_type(self.mtype.as(MClassType))
544 end
545 end
546
547 redef class AIntegerExpr
548 redef fun accept_rapid_type_visitor(v)
549 do
550 allocate_mtype(v)
551 end
552 end
553
554 redef class AFloatExpr
555 redef fun accept_rapid_type_visitor(v)
556 do
557 allocate_mtype(v)
558 end
559 end
560
561 redef class ACharExpr
562 redef fun accept_rapid_type_visitor(v)
563 do
564 allocate_mtype(v)
565 end
566 end
567
568 redef class AArrayExpr
569 redef fun accept_rapid_type_visitor(v)
570 do
571 var mtype = self.mtype.as(MClassType)
572 v.add_type(mtype)
573 var native = v.analysis.mainmodule.native_array_type(mtype.arguments.first)
574 v.add_type(native)
575 mtype = v.cleanup_type(mtype).as(not null)
576 var prop = v.get_method(mtype, "with_native")
577 v.add_monomorphic_send(mtype, prop)
578 v.add_callsite(with_capacity_callsite)
579 v.add_callsite(push_callsite)
580 end
581 end
582
583 redef class AStringFormExpr
584 redef fun accept_rapid_type_visitor(v)
585 do
586 var native = v.analysis.mainmodule.native_string_type
587 v.add_type(native)
588 var prop = v.get_method(native, "to_s_full")
589 v.add_monomorphic_send(native, prop)
590 v.add_callsite(to_re)
591 v.add_callsite(ignore_case)
592 v.add_callsite(newline)
593 v.add_callsite(extended)
594 v.add_callsite(to_bytes_with_copy)
595 end
596 end
597
598 redef class ASuperstringExpr
599 redef fun accept_rapid_type_visitor(v)
600 do
601 var mmodule = v.analysis.mainmodule
602 var object_type = mmodule.string_type
603 var arraytype = mmodule.array_type(object_type)
604 v.add_type(arraytype)
605 var nattype = mmodule.native_array_type(object_type)
606 v.add_type(nattype)
607 var prop = v.get_method(arraytype, "join")
608 v.add_monomorphic_send(arraytype, prop)
609 var prop2 = v.get_method(arraytype, "with_native")
610 v.add_monomorphic_send(arraytype, prop2)
611 v.add_monomorphic_send(nattype, v.get_method(nattype, "native_to_s"))
612 end
613 end
614
615 redef class ACrangeExpr
616 redef fun accept_rapid_type_visitor(v)
617 do
618 var mtype = self.mtype
619 if not mtype isa MClassType then return
620 v.add_type(mtype)
621 v.add_callsite(init_callsite)
622 end
623 end
624
625 redef class AOrangeExpr
626 redef fun accept_rapid_type_visitor(v)
627 do
628 var mtype = self.mtype
629 if not mtype isa MClassType then return
630 v.add_type(mtype)
631 v.add_callsite(init_callsite)
632 end
633 end
634
635 redef class ATrueExpr
636 redef fun accept_rapid_type_visitor(v)
637 do
638 allocate_mtype(v)
639 end
640 end
641
642 redef class AFalseExpr
643 redef fun accept_rapid_type_visitor(v)
644 do
645 allocate_mtype(v)
646 end
647 end
648
649 redef class AIsaExpr
650 redef fun accept_rapid_type_visitor(v)
651 do
652 var cast_type = self.cast_type
653 if cast_type == null then return
654 v.add_cast_type(cast_type)
655 end
656 end
657
658 redef class AAsCastExpr
659 redef fun accept_rapid_type_visitor(v)
660 do
661 var mtype = self.mtype
662 if mtype == null then return
663 v.add_cast_type(mtype)
664 end
665 end
666
667 redef class ASendExpr
668 redef fun accept_rapid_type_visitor(v)
669 do
670 v.add_callsite(callsite)
671 end
672 end
673
674
675 redef class ASendReassignFormExpr
676 redef fun accept_rapid_type_visitor(v)
677 do
678 v.add_callsite(callsite)
679 v.add_callsite(reassign_callsite)
680 v.add_callsite(write_callsite)
681 end
682 end
683
684 redef class AVarReassignExpr
685 redef fun accept_rapid_type_visitor(v)
686 do
687 v.add_callsite(reassign_callsite)
688 end
689 end
690
691 redef class AAttrReassignExpr
692 redef fun accept_rapid_type_visitor(v)
693 do
694 v.add_callsite(reassign_callsite)
695 end
696 end
697
698 redef class ASuperExpr
699 redef fun accept_rapid_type_visitor(v)
700 do
701 var callsite = self.callsite
702 if callsite != null then
703 v.add_callsite(callsite)
704 return
705 end
706
707 v.analysis.add_super_send(v.receiver, mpropdef.as(not null))
708 end
709 end
710
711 redef class AForGroup
712 redef fun accept_rapid_type_visitor(v)
713 do
714 v.add_callsite(self.method_iterator)
715 v.add_callsite(self.method_is_ok)
716 if self.variables.length == 1 then
717 v.add_callsite(self.method_item)
718 else if self.variables.length == 2 then
719 v.add_callsite(self.method_key)
720 v.add_callsite(self.method_item)
721 else
722 abort
723 end
724 v.add_callsite(self.method_next)
725 var mf = self.method_finish
726 if mf != null then v.add_callsite(mf)
727 end
728 end
729
730 redef class ANewExpr
731 redef fun accept_rapid_type_visitor(v)
732 do
733 var mtype = self.recvtype.as(not null)
734 v.add_type(mtype)
735 v.add_callsite(callsite)
736 end
737 end