Merge: Added contributing guidelines and link from readme
[nit.git] / src / rapid_type_analysis.nit
1 # This file is part of NIT ( http://www.nitlanguage.org ).
2 #
3 # Copyright 2012 Jean Privat <jean@pryen.org>
4 #
5 # Licensed under the Apache License, Version 2.0 (the "License");
6 # you may not use this file except in compliance with the License.
7 # You may obtain a copy of the License at
8 #
9 # http://www.apache.org/licenses/LICENSE-2.0
10 #
11 # Unless required by applicable law or agreed to in writing, software
12 # distributed under the License is distributed on an "AS IS" BASIS,
13 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14 # See the License for the specific language governing permissions and
15 # limitations under the License.
16
17
18 # Rapid type analysis on the AST
19 #
20 # Rapid type analysis is an analyse that aproximates the set of live classes
21 # and the set of live methods starting from the entry point of the program.
22 # These two sets are interdependant and computed together.
23 # It is quite efficient but the type set is global and pollutes each call site.
24 module rapid_type_analysis
25
26 import semantize
27
28 import csv # for live_types_to_csv
29 private import ordered_tree # for live_methods_to_tree
30
31 private import more_collections
32
33 redef class ModelBuilder
34 # Performs a rapid-type-analysis on the program associated with `mainmodule`.
35 fun do_rapid_type_analysis(mainmodule: MModule): RapidTypeAnalysis
36 do
37 var analysis = new RapidTypeAnalysis(self, mainmodule)
38 analysis.run_analysis
39
40 if toolcontext.opt_log.value then
41 var basename = toolcontext.log_directory / mainmodule.name
42 analysis.live_methods_to_tree.write_to_file(basename + ".rta_methods.txt")
43 analysis.live_types_to_csv.write_to_file(basename + ".rta_types.csv")
44 end
45
46 return analysis
47 end
48 end
49
50 # RapidTypeAnalysis looks for alive rapid types in application.
51 # The entry point of the analysis is the mainmodule of the application.
52 class RapidTypeAnalysis
53 # The modelbuilder used to get the AST.
54 var modelbuilder: ModelBuilder
55
56 # The main module of the analysis.
57 # Used to perform types operations.
58 var mainmodule: MModule
59
60 # The pool to live types.
61 # During the analysis, new types are added and combined with
62 # live_methods to determine new methoddefs to visit
63 var live_types = new HashSet[MClassType]
64
65 # The pool of undesolved live types
66 # They are globally resolved at the end of the analaysis
67 var live_open_types = new HashSet[MClassType]
68
69 # Live (instantiated) classes.
70 var live_classes = new HashSet[MClass]
71
72 # The pool of types used to perform type checks (isa and as).
73 var live_cast_types = new HashSet[MType]
74
75 # The pool of undesolved types used to perform type checks (isa and as).
76 # They are globally resolved at the end of the analaysis
77 var live_open_cast_types = new HashSet[MType]
78
79 # Live method definitions.
80 var live_methoddefs = new HashSet[MMethodDef]
81
82 # Live methods.
83 var live_methods = new HashSet[MMethod]
84
85 # Live mmodules.
86 # Those with a live method definitions (see `live_methoddefs`)
87 var live_mmodules = new HashSet[MModule]
88
89 # Live callsites.
90 var live_callsites = new HashSet[CallSite]
91
92 private var live_targets_cache = new HashMap2[MType, MProperty, Set[MMethodDef]]
93
94 # The live targets of a specific callsite.
95 fun live_targets(callsite: CallSite): Set[MMethodDef]
96 do
97 var mtype = callsite.recv
98 var anchor = callsite.anchor
99 if anchor != null then mtype = mtype.anchor_to(callsite.mmodule, anchor)
100 mtype = mtype.undecorate
101 if mtype isa MClassType then mtype = mtype.mclass.intro.bound_mtype
102 var mproperty = callsite.mproperty
103 var res = live_targets_cache[mtype, mproperty]
104 if res != null then return res
105 res = new ArraySet[MMethodDef]
106 live_targets_cache[mtype, mproperty] = res
107
108 for c in live_classes do
109 var tc = c.intro.bound_mtype
110 if not tc.is_subtype(mainmodule, null, mtype) then continue
111 var d = mproperty.lookup_first_definition(mainmodule, tc)
112 res.add d
113 end
114
115 return res
116 end
117
118 # Live call-to-super.
119 var live_super_sends = new HashSet[MMethodDef]
120
121 # Return a ready-to-save CSV document objet that agregates informations about live types.
122 # Each discovered type is listed in a line, with its status: resolution, liveness, cast-liveness.
123 # Note: types are listed in an alphanumeric order to improve human reading.
124 fun live_types_to_csv: CsvDocument
125 do
126 # Gather all kind of type
127 var typeset = new HashSet[MType]
128 typeset.add_all(live_types)
129 typeset.add_all(live_open_types)
130 typeset.add_all(live_cast_types)
131 typeset.add_all(live_open_cast_types)
132 var types = typeset.to_a
133 (new CachedAlphaComparator).sort(types)
134 var res = new CsvDocument
135 res.separator = ';'
136 res.header = ["Type", "Resolution", "Liveness", "Cast-liveness"]
137 for t in types do
138 var reso
139 if t.need_anchor then reso = "OPEN " else reso = "CLOSED"
140 var live
141 if t isa MClassType and (live_types.has(t) or live_open_types.has(t)) then live = "LIVE" else live = "DEAD"
142 var cast
143 if live_cast_types.has(t) or live_open_cast_types.has(t) then cast = "CAST LIVE" else cast = "CAST DEAD"
144 res.add_record(t, reso, live, cast)
145 end
146 return res
147 end
148
149 # Return a ready-to-save OrderedTree object that agregates infomration about live methods.
150 # Note: methods are listed in an alphanumeric order to improve human reading.
151 fun live_methods_to_tree: OrderedTree[Object]
152 do
153 var tree = new OrderedTree[Object]
154 for x in live_methods do
155 var xn = x.full_name
156 tree.add(null, xn)
157 for z in x.mpropdefs do
158 var zn = z.to_s
159 if live_methoddefs.has(z) then
160 tree.add(xn, zn)
161 if live_super_sends.has(z) then
162 tree.add(zn, zn + "(super)")
163 end
164 else if live_super_sends.has(z) then
165 tree.add(xn, zn + "(super)")
166 end
167 end
168 end
169 tree.sort_with(alpha_comparator)
170 return tree
171 end
172
173 # Methods that are still candidate to the try_send
174 private var totry_methods = new HashSet[MMethod]
175
176 # Methods that are are no more candidate to the try_send
177 private var totry_methods_to_remove = new Array[MMethod]
178
179 # Methods that are or were candidate to the try_send
180 # Used to ensure that try_send is only used once
181 private var try_methods = new HashSet[MMethod]
182
183 # The method definitions that remain to visit
184 private var todo = new List[MMethodDef]
185
186 private fun force_alive(classname: String)
187 do
188 var classes = self.modelbuilder.model.get_mclasses_by_name(classname)
189 if classes != null then for c in classes do self.add_new(c.mclass_type, c.mclass_type)
190 end
191
192 # Run the analysis until all visitable method definitions are visited.
193 fun run_analysis
194 do
195 var maintype = mainmodule.sys_type
196 if maintype == null then return # No entry point
197 add_new(maintype, maintype)
198 var initprop = mainmodule.try_get_primitive_method("init", maintype.mclass)
199 if initprop != null then
200 add_send(maintype, initprop)
201 end
202 var mainprop = mainmodule.try_get_primitive_method("run", maintype.mclass) or else
203 mainmodule.try_get_primitive_method("main", maintype.mclass)
204 if mainprop != null then
205 add_send(maintype, mainprop)
206 end
207
208 var finalizable_type = mainmodule.finalizable_type
209 if finalizable_type != null then
210 var finalize_meth = mainmodule.try_get_primitive_method("finalize", finalizable_type.mclass)
211 if finalize_meth != null then add_send(finalizable_type, finalize_meth)
212 end
213
214 # Force primitive types
215 force_alive("Bool")
216 force_alive("Float")
217 force_alive("Char")
218 force_alive("Pointer")
219 force_alive("Byte")
220 force_alive("Int")
221 force_alive("Int8")
222 force_alive("Int16")
223 force_alive("UInt16")
224 force_alive("Int32")
225 force_alive("UInt32")
226
227 while not todo.is_empty do
228 var mmethoddef = todo.shift
229 var mmeth = mmethoddef.mproperty
230 var msignature = mmethoddef.msignature
231 if msignature == null then continue # Skip broken method
232
233 #print "# visit {mmethoddef}"
234 var v = new RapidTypeVisitor(self, mmethoddef.mclassdef.bound_mtype, mmethoddef)
235
236 var vararg_rank = msignature.vararg_rank
237 if vararg_rank > -1 then
238 var node = self.modelbuilder.mpropdef2node(mmethoddef)
239 var elttype = msignature.mparameters[vararg_rank].mtype
240 #elttype = elttype.anchor_to(self.mainmodule, v.receiver)
241 var vararg = self.mainmodule.array_type(elttype)
242 v.add_type(vararg)
243 var native = self.mainmodule.native_array_type(elttype)
244 v.add_type(native)
245 v.add_monomorphic_send(vararg, self.modelbuilder.force_get_primitive_method(node, "with_native", vararg.mclass, self.mainmodule))
246 end
247
248 # TODO? new_msignature
249 var sig = msignature
250 var osig = mmeth.intro.msignature.as(not null)
251 for i in [0..sig.arity[ do
252 var origtype = osig.mparameters[i].mtype
253 if not origtype.need_anchor then continue # skip non covariant stuff
254 var paramtype = sig.mparameters[i].mtype
255 add_cast(paramtype)
256 end
257
258 if mmethoddef.is_abstract then continue
259
260 var npropdef = modelbuilder.mpropdef2node(mmethoddef)
261
262 if npropdef isa AClassdef then
263 if mmethoddef.mproperty.is_root_init then
264 if not mmethoddef.is_intro then
265 self.add_super_send(v.receiver, mmethoddef)
266 end
267 else
268 npropdef.debug "cannot RTA {mmethoddef}"
269 abort
270 end
271 continue
272 else if mmethoddef.constant_value != null then
273 # Make the return type live
274 v.add_type(msignature.return_mtype.as(MClassType))
275 continue
276 else if npropdef == null then
277 abort
278 end
279
280 if npropdef isa AMethPropdef then
281 var auto_super_inits = npropdef.auto_super_inits
282 if auto_super_inits != null then
283 for auto_super_init in auto_super_inits do
284 v.add_callsite(auto_super_init)
285 end
286 end
287 if npropdef.auto_super_call then
288 self.add_super_send(v.receiver, mmethoddef)
289 end
290 end
291
292 if mmethoddef.is_intern or mmethoddef.is_extern then
293 # UGLY: We force the "instantation" of the concrete return type if any
294 var ret = msignature.return_mtype
295 if ret != null and ret isa MClassType and ret.mclass.kind != abstract_kind and ret.mclass.kind != interface_kind then
296 v.add_type(ret)
297 end
298 end
299
300 v.enter_visit(npropdef)
301 end
302
303 #print "MMethod {live_methods.length}: {live_methods.join(", ")}"
304 #print "MMethodDef {live_methoddefs.length}: {live_methoddefs.join(", ")}"
305
306 #print "open MType {live_open_types.length}: {live_open_types.join(", ")}"
307 var todo_types = new List[MClassType]
308 todo_types.add_all(live_types)
309 while not todo_types.is_empty do
310 var t = todo_types.shift
311 for ot in live_open_types do
312 #print "{ot}/{t} ?"
313 if not ot.can_resolve_for(t, t, mainmodule) then continue
314 var rt = ot.anchor_to(mainmodule, t)
315 if live_types.has(rt) then continue
316 if not check_depth(rt) then continue
317 #print "{ot}/{t} -> {rt}"
318 live_types.add(rt)
319 # unshift means a deep-first visit.
320 # So that the `check_depth` limit is reached sooner.
321 todo_types.unshift(rt)
322 end
323 end
324 #print "MType {live_types.length}: {live_types.join(", ")}"
325
326 #print "open cast MType {live_open_cast_types.length}: {live_open_cast_types.join(", ")}"
327 for ot in live_open_cast_types do
328 #print "live_open_cast_type: {ot}"
329 for t in live_types do
330 if not ot.can_resolve_for(t, t, mainmodule) then continue
331 var rt = ot.anchor_to(mainmodule, t)
332 live_cast_types.add(rt)
333 #print " {ot}/{t} -> {rt}"
334 end
335 end
336 #print "cast MType {live_cast_types.length}: {live_cast_types.join(", ")}"
337 end
338
339 private fun check_depth(mtype: MClassType): Bool
340 do
341 var d = mtype.length
342 if d > 255 then
343 self.modelbuilder.toolcontext.fatal_error(null, "Fatal Error: limitation in the rapidtype analysis engine: a type depth of {d} is too important, the problematic type is `{mtype}`.")
344 return false
345 end
346 return true
347 end
348
349 fun add_new(recv: MClassType, mtype: MClassType)
350 do
351 assert not recv.need_anchor
352 if mtype.need_anchor then
353 if live_open_types.has(mtype) then return
354 live_open_types.add(mtype)
355 else
356 if live_types.has(mtype) then return
357 live_types.add(mtype)
358 end
359
360 var mclass = mtype.mclass
361 if live_classes.has(mclass) then return
362 live_classes.add(mclass)
363
364 for p in totry_methods do try_send(mtype, p)
365 for p in live_super_sends do try_super_send(mtype, p)
366
367 # Remove cleared ones
368 for p in totry_methods_to_remove do totry_methods.remove(p)
369 totry_methods_to_remove.clear
370
371 var bound_mtype = mtype.anchor_to(mainmodule, recv)
372 for cd in bound_mtype.collect_mclassdefs(mainmodule)
373 do
374 for npropdef in modelbuilder.collect_attr_propdef(cd) do
375 if not npropdef.has_value then continue
376
377 var mpropdef = npropdef.mreadpropdef.as(not null)
378 var v = new RapidTypeVisitor(self, bound_mtype, mpropdef)
379 v.enter_visit(npropdef.n_expr)
380 v.enter_visit(npropdef.n_block)
381 end
382 end
383
384 end
385
386 fun add_cast(mtype: MType)
387 do
388 if mtype.need_anchor then
389 live_open_cast_types.add(mtype)
390 else
391 live_cast_types.add(mtype)
392 end
393 end
394
395 fun try_send(recv: MClassType, mproperty: MMethod)
396 do
397 recv = recv.mclass.intro.bound_mtype
398 if not recv.has_mproperty(mainmodule, mproperty) then return
399 var d = mproperty.lookup_first_definition(mainmodule, recv)
400 add_call(d)
401 end
402
403 fun add_call(mpropdef: MMethodDef)
404 do
405 if live_methoddefs.has(mpropdef) then return
406 live_methoddefs.add(mpropdef)
407 live_mmodules.add(mpropdef.mclassdef.mmodule)
408 todo.add(mpropdef)
409
410 var mproperty = mpropdef.mproperty
411 if mproperty.mpropdefs.length <= 1 then return
412 # If all definitions of a method are live, we can remove the definition of the totry set
413 for d in mproperty.mpropdefs do
414 if not live_methoddefs.has(d) then return
415 end
416 #print "full property: {mpropdef.mproperty} for {mpropdef.mproperty.mpropdefs.length} definitions"
417 totry_methods_to_remove.add(mpropdef.mproperty)
418 end
419
420 fun add_send(recv: MType, mproperty: MMethod)
421 do
422 if try_methods.has(mproperty) then return
423 #print "new prop: {mproperty}"
424 live_methods.add(mproperty)
425 try_methods.add(mproperty)
426 if mproperty.mpropdefs.length == 1 then
427 # If there is only one definition, just add the definition and do not try again the property
428 var d = mproperty.mpropdefs.first
429 add_call(d)
430 return
431 end
432 # Else, the property is potentially called with various reciever
433 # So just try the methods with existing receiver and register it for future receiver
434 totry_methods.add(mproperty)
435 for c in live_classes do
436 try_send(c.intro.bound_mtype, mproperty)
437 end
438 end
439
440 fun try_super_send(recv: MClassType, mpropdef: MMethodDef)
441 do
442 recv = recv.mclass.intro.bound_mtype
443 if not recv.collect_mclassdefs(mainmodule).has(mpropdef.mclassdef) then return
444 var d = mpropdef.lookup_next_definition(mainmodule, recv)
445 add_call(d)
446 end
447
448 fun add_super_send(recv: MType, mpropdef: MMethodDef)
449 do
450 assert mpropdef.has_supercall
451 if live_super_sends.has(mpropdef) then return
452 #print "new super prop: {mpropdef}"
453 live_super_sends.add(mpropdef)
454 for c in live_classes do
455 try_super_send(c.intro.bound_mtype, mpropdef)
456 end
457 end
458 end
459
460 class RapidTypeVisitor
461 super Visitor
462
463 var analysis: RapidTypeAnalysis
464 var receiver: MClassType
465 var mpropdef: MPropDef
466
467 init
468 do
469 assert not receiver.need_anchor
470 end
471
472 redef fun visit(n)
473 do
474 if n isa AExpr then
475 if n.mtype != null or n.is_typed then
476 n.accept_rapid_type_visitor(self)
477 var implicit_cast_to = n.implicit_cast_to
478 if implicit_cast_to != null then self.add_cast_type(implicit_cast_to)
479 end
480 else
481 n.accept_rapid_type_visitor(self)
482 end
483
484 # RTA does not enter in AAnnotations
485 if not n isa AAnnotations then
486 n.visit_all(self)
487 end
488 end
489
490 fun cleanup_type(mtype: MType): nullable MClassType
491 do
492 mtype = mtype.anchor_to(self.analysis.mainmodule, self.receiver)
493 if mtype isa MNullType then return null
494 mtype = mtype.undecorate
495 assert mtype isa MClassType
496 assert not mtype.need_anchor
497 return mtype
498 end
499
500 fun get_method(recv: MType, name: String): MMethod
501 do
502 var mtype = cleanup_type(recv)
503 assert mtype != null
504 return self.analysis.modelbuilder.force_get_primitive_method(self.current_node.as(not null), name, mtype.mclass, self.analysis.mainmodule)
505 end
506
507 fun add_type(mtype: MClassType) do analysis.add_new(receiver, mtype)
508
509 fun add_monomorphic_send(mtype: MType, mproperty: MMethod)
510 do
511 analysis.live_methods.add(mproperty)
512 analysis.try_send(mtype.as(MClassType), mproperty)
513 end
514
515 fun add_send(mtype: MType, mproperty: MMethod) do analysis.add_send(mtype, mproperty)
516
517 fun add_cast_type(mtype: MType) do analysis.add_cast(mtype)
518
519 fun add_callsite(callsite: nullable CallSite) do if callsite != null then
520 for m in callsite.mpropdef.initializers do
521 if m isa MMethod then
522 analysis.add_send(callsite.recv, m)
523 end
524 end
525 analysis.add_send(callsite.recv, callsite.mproperty)
526 analysis.live_callsites.add(callsite)
527 end
528 end
529
530 ###
531
532 redef class ANode
533 private fun accept_rapid_type_visitor(v: RapidTypeVisitor)
534 do
535 end
536 end
537
538 redef class AExpr
539 # Make the `mtype` of the expression live
540 # Used by literals and instantiations
541 fun allocate_mtype(v: RapidTypeVisitor)
542 do
543 var mtype = self.mtype
544 if not mtype isa MClassType then return
545 v.add_type(self.mtype.as(MClassType))
546 end
547 end
548
549 redef class AIntegerExpr
550 redef fun accept_rapid_type_visitor(v)
551 do
552 allocate_mtype(v)
553 end
554 end
555
556 redef class AFloatExpr
557 redef fun accept_rapid_type_visitor(v)
558 do
559 allocate_mtype(v)
560 end
561 end
562
563 redef class ACharExpr
564 redef fun accept_rapid_type_visitor(v)
565 do
566 allocate_mtype(v)
567 end
568 end
569
570 redef class AArrayExpr
571 redef fun accept_rapid_type_visitor(v)
572 do
573 var mtype = self.mtype.as(MClassType)
574 v.add_type(mtype)
575 var native = v.analysis.mainmodule.native_array_type(mtype.arguments.first)
576 v.add_type(native)
577 mtype = v.cleanup_type(mtype).as(not null)
578 var prop = v.get_method(mtype, "with_native")
579 v.add_monomorphic_send(mtype, prop)
580 v.add_callsite(with_capacity_callsite)
581 v.add_callsite(push_callsite)
582 end
583 end
584
585 redef class AStringFormExpr
586 redef fun accept_rapid_type_visitor(v)
587 do
588 var native = v.analysis.mainmodule.native_string_type
589 v.add_type(native)
590 var prop = v.get_method(native, "to_s_full")
591 v.add_monomorphic_send(native, prop)
592 v.add_callsite(to_re)
593 v.add_callsite(ignore_case)
594 v.add_callsite(newline)
595 v.add_callsite(extended)
596 v.add_callsite(to_bytes_with_copy)
597 end
598 end
599
600 redef class ASuperstringExpr
601 redef fun accept_rapid_type_visitor(v)
602 do
603 var mmodule = v.analysis.mainmodule
604 var object_type = mmodule.string_type
605 var arraytype = mmodule.array_type(object_type)
606 v.add_type(arraytype)
607 var nattype = mmodule.native_array_type(object_type)
608 v.add_type(nattype)
609 var prop = v.get_method(arraytype, "join")
610 v.add_monomorphic_send(arraytype, prop)
611 var prop2 = v.get_method(arraytype, "with_native")
612 v.add_monomorphic_send(arraytype, prop2)
613 v.add_monomorphic_send(nattype, v.get_method(nattype, "native_to_s"))
614 end
615 end
616
617 redef class ACrangeExpr
618 redef fun accept_rapid_type_visitor(v)
619 do
620 var mtype = self.mtype
621 if not mtype isa MClassType then return
622 v.add_type(mtype)
623 v.add_callsite(init_callsite)
624 end
625 end
626
627 redef class AOrangeExpr
628 redef fun accept_rapid_type_visitor(v)
629 do
630 var mtype = self.mtype
631 if not mtype isa MClassType then return
632 v.add_type(mtype)
633 v.add_callsite(init_callsite)
634 end
635 end
636
637 redef class ATrueExpr
638 redef fun accept_rapid_type_visitor(v)
639 do
640 allocate_mtype(v)
641 end
642 end
643
644 redef class AFalseExpr
645 redef fun accept_rapid_type_visitor(v)
646 do
647 allocate_mtype(v)
648 end
649 end
650
651 redef class AIsaExpr
652 redef fun accept_rapid_type_visitor(v)
653 do
654 var cast_type = self.cast_type
655 if cast_type == null then return
656 v.add_cast_type(cast_type)
657 end
658 end
659
660 redef class AAsCastExpr
661 redef fun accept_rapid_type_visitor(v)
662 do
663 var mtype = self.mtype
664 if mtype == null then return
665 v.add_cast_type(mtype)
666 end
667 end
668
669 redef class ASendExpr
670 redef fun accept_rapid_type_visitor(v)
671 do
672 v.add_callsite(callsite)
673 end
674 end
675
676
677 redef class ASendReassignFormExpr
678 redef fun accept_rapid_type_visitor(v)
679 do
680 v.add_callsite(callsite)
681 v.add_callsite(reassign_callsite)
682 v.add_callsite(write_callsite)
683 end
684 end
685
686 redef class AVarReassignExpr
687 redef fun accept_rapid_type_visitor(v)
688 do
689 v.add_callsite(reassign_callsite)
690 end
691 end
692
693 redef class AAttrReassignExpr
694 redef fun accept_rapid_type_visitor(v)
695 do
696 v.add_callsite(reassign_callsite)
697 end
698 end
699
700 redef class ASuperExpr
701 redef fun accept_rapid_type_visitor(v)
702 do
703 var callsite = self.callsite
704 if callsite != null then
705 v.add_callsite(callsite)
706 return
707 end
708
709 v.analysis.add_super_send(v.receiver, mpropdef.as(not null))
710 end
711 end
712
713 redef class AForGroup
714 redef fun accept_rapid_type_visitor(v)
715 do
716 v.add_callsite(self.method_iterator)
717 v.add_callsite(self.method_is_ok)
718 if self.variables.length == 1 then
719 v.add_callsite(self.method_item)
720 else if self.variables.length == 2 then
721 v.add_callsite(self.method_key)
722 v.add_callsite(self.method_item)
723 else
724 abort
725 end
726 v.add_callsite(self.method_next)
727 var mf = self.method_finish
728 if mf != null then v.add_callsite(mf)
729 end
730 end
731
732 redef class ANewExpr
733 redef fun accept_rapid_type_visitor(v)
734 do
735 var mtype = self.recvtype.as(not null)
736 v.add_type(mtype)
737 v.add_callsite(callsite)
738 end
739 end